On upgrade from Debian 8 to Debian 9 the resultant DBI driver update alters the returned precision for numeric values. This causes some of the test suit to start failing.
Created attachment 75916 [details] [review] Bug 20906: Prevent test failures due to precision changes
On upgrade from Debian 8 to Debian 9 the resultant Perl update means perl strict is 'more strict' ;)
Created attachment 75920 [details] [review] Bug 20906: Prevent test failures due to stricter perl
Created attachment 75921 [details] [review] Bug 20906: Prevent test failures due to precision changes (2)
I'm not proud of that last one.. it fixes the tests but I'd rather convert the float for discount in the database to a decimal to match the decimal that's used for tax_rate (which is also a percentage measured to the same accuracy.. seems odd to have them stored differently).. but that seemed over the top here.
Test plan.. run the affected tests against both D8 and D9 and see that they now pass ;) Beware, running 00_strict requires WebService::ILS::OverDrive is installed.. KohaDevBox is missing it in my experience.
Created attachment 75929 [details] [review] Bug 20906: Fix translatable-templates.t From Jenkins: koha_1 | # Failed test 'staff_prog templates are translatable' koha_1 | # at xt/author/translatable-templates.t line 87. koha_1 | # Can't locate TmplTokenizer.pm in @INC (you may need to install the TmplTokenizer module) (@INC contains: /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at ./tmpl_process3.pl line 20. On Stretch, '.' is not longer added to @INC, see bug 17717 for more info
Upping severity, we need it pushed ASAP
Created attachment 76175 [details] [review] Bug 20906: Prevent test failures due to precision changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 76176 [details] [review] Bug 20906: Prevent test failures due to stricter perl Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 76177 [details] [review] Bug 20906: Prevent test failures due to precision changes (2) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 76178 [details] [review] Bug 20906: Fix translatable-templates.t From Jenkins: koha_1 | # Failed test 'staff_prog templates are translatable' koha_1 | # at xt/author/translatable-templates.t line 87. koha_1 | # Can't locate TmplTokenizer.pm in @INC (you may need to install the TmplTokenizer module) (@INC contains: /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at ./tmpl_process3.pl line 20. On Stretch, '.' is not longer added to @INC, see bug 17717 for more info Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This is simple enough to skip other QA step. It was written by two QA team members...
Awesome work all! Pushed to master for 18.11.x
Pushed to 18.05.x for 18.05.02
Pushed to 17.11.x, will be in v17.11.08
No need of Debian 9 compatibility for 17.05.x