Created attachment 76000 [details] [review] Patch for debian/control The Debian/Ubuntu package is missing a dependency on libcgi-compile-perl. Without this package installed, when Plack is enabled/started, the webserver is unresponsive and the following errors appear in the logs: Error while loading /etc/koha/plack.psgi: Can't locate CGI/Compile.pm in @INC (you may need to install the CGI::Compile module) (@INC contains: /usr/share/koha/lib /us r/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5 /5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /usr/share/perl5/Plack /App/WrapCGI.pm line 8. BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/WrapCGI.pm line 8. Compilation failed in require at /usr/share/perl5/Plack/App/CGIBin.pm line 6. BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/CGIBin.pm line 6. Compilation failed in require at /etc/koha/plack.psgi line 21. BEGIN failed--compilation aborted at /etc/koha/plack.psgi line 21. Attached is a patch to add this package to the debian/control file.
Which versions of Debian and/or Ubuntu did you test?
Debian 9.4 (stretch)
libcgi-compile-perl is 'recommended' by libplack-perl, which gets it installed on most systems. Apparently koha depends on it. Not sure why it is only recommended by libplack-perl, but that's a different story. The control file is not supposed to be patched, as stated in the file itself. > # Do not manually edit "control" CGI::Compile needs to be added to PerlDependencies.pm. I will take care of updating the control file afterwards.
Created attachment 76217 [details] [review] bug 20920: patch to PerlDependencies.pm adding CGI::Compile
Created attachment 76589 [details] [review] Bug 20920: Add missing dependency on CGI::Compile Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 76590 [details] [review] Bug 20920: Followup: generated d/control Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Jerome, thanks a lot for spotting the problem and your patch! Minor QA change: first line of the commit message is supposed to be Bug xxxxx: Your bug report title I changed it and generated the new control file. Nick, please push, I will do a 18.05.01-2 and probably 17.11.07-2 package with this because it breaks fresh Koha with Plack on Stretch.
Martin: is in 18.05.01-2, please push to 18.05.02. Fridolin: is in 17.11.07-2, please push to 17.11.08. Depends on 20693 for 17.11.x, please push the other one first.
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02
Pushed to 17.11.x for 17.11.08