Koha::Patron::Discharge is missing use Koha::Patron::Debarments used in discharge() method.
Created attachment 76093 [details] [review] Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method. Test plan : 1) Enable pref useDischarge 2) Go to OPAC user page 3) Go to 'ask for a discharge' tab 4) Click on 'Ask for a discharge' 5) Go to staff interface : /cgi-bin/koha/members/discharges.pl 6) Click on Allow => Without patch you get software error => With patch the discharge is validated
I can't reproduce the problem. I have tried discharging from the patron account as well as discharging using the link from the dashboard and the 'allow' button. Similar to bug 20851?
Created attachment 76167 [details] [review] Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method. Test plan : 1) Enable pref useDischarge 2) Go to OPAC user page 3) Go to 'ask for a discharge' tab 4) Click on 'Ask for a discharge' 5) Go to staff interface : /cgi-bin/koha/members/discharges.pl 6) Click on Allow => Without patch you get software error => With patch the discharge is validated Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=20953
Created attachment 76194 [details] [review] Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method. Test plan : 1) Enable pref useDischarge 2) Go to OPAC user page 3) Go to 'ask for a discharge' tab 4) Click on 'Ask for a discharge' 5) Go to staff interface : /cgi-bin/koha/members/discharges.pl 6) Click on Allow => Without patch you get software error => With patch the discharge is validated Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11.x
Pushed to 18.05.x for 18.05.02
(In reply to Katrin Fischer from comment #2) > I can't reproduce the problem. I have tried discharging from the patron > account as well as discharging using the link from the dashboard and the > 'allow' button. > > Similar to bug 20851? I should have mentioned I'm in Plack env. I see the explanation in Bug 20851. I think each module should explicitly call use on the modules they need.
Pushed to 17.11.x for 17.11.08
Pushed to 17.05.x for 17.05.14