I think we should remove the "show all details" checkbox from acqui/basket.pl and replace it with DataTables column configuration.
Created attachment 76179 [details] [review] Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket.
Hullo, when I click on column visibility I don't get any options to show/hide columns, it is empty.
Created attachment 77891 [details] [review] Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
some restart_all magic fixes everything. Signed off
(In reply to Owen Leonard from comment #0) > I think we should remove the "show all details" checkbox from > acqui/basket.pl and replace it with DataTables column configuration. I think we should keep the link, now we need 4 clicks to display/hide these columns.
Hi Owen, could you take a look at Jonathan's comment#5 and see if that could be done? Sadly with the recent changes to the templates (filters) this no longer applies. Please rebase!
(In reply to Jonathan Druart from comment #5) > I think we should keep the link, now we need 4 clicks to display/hide these > columns. I think it's inconsistent to have one method of showing and hiding columns on this page and another method elsewhere (this is true also for batch record modification, which should be updated).
Created attachment 78310 [details] [review] Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 80404 [details] [review] Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
I had an in-person discussion at KohaCon about this issue and got some positive feedback on the change. I'm hoping folks will take another look.
Hi Owen, I think we should do this, I've tested and the column config makes it quite easy to change the display quickly too. Still found some issues: 1) I am not sure if the html filter would be correct here, can you please check? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL filters missing_filter at line 808 ( var columns_settings = [% ColumnsSettings.GetColumns( 'acqui', 'basket', 'orders', 'json' ) %];) 2) Can we suppress the Action columns when exporting to Excel? The line breaks in the 'reason' for not being able to delete the entry also create issues with the formatting (Cancel order Can't cancel order and delete catalog record 2 item(s) left 1 subscription(s) left)
Created attachment 81498 [details] [review] Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported.
Hi Owen, something about the stored columns settings is wrong - it doesn't seem to take into account the default configuration from administration I checked hidden by default and not toggable for the "Supplier report", but it won't go away.
Created attachment 81636 [details] [review] Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported.
(In reply to Katrin Fischer from comment #13) > I checked hidden by default and not toggable for the "Supplier report", but > it won't go away. Yes, I didn't see that Bug 18639 had added a column, requiring a change to columns_settings.yml.
Created attachment 81792 [details] [review] Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81793 [details] [review] Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81910 [details] [review] Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=20996
Created attachment 81911 [details] [review] Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=20996
Works well, no regressions found.. passed qa
Please rebase
Created attachment 82134 [details] [review] Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=20996
Created attachment 82135 [details] [review] Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=20996
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.