Bug 20970 - Reformat basket information on acquisitions basket page
Summary: Reformat basket information on acquisitions basket page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-20 16:00 UTC by Owen Leonard
Modified: 2019-10-14 19:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
GIF showing new forms interaction (53.17 KB, image/gif)
2018-06-20 16:00 UTC, Owen Leonard
Details
Bug 20970: Reformat basket information on acquisitions basket page (19.76 KB, patch)
2018-06-20 16:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20970: Reformat basket information on acquisitions basket page (19.71 KB, patch)
2018-08-06 19:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20970: (follow-up) Reformat basket information on acquisitions basket page (9.41 KB, patch)
2018-08-07 13:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20970: Reformat basket information on acquisitions basket page (21.37 KB, patch)
2018-09-20 12:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20970: Reformat basket information on acquisitions basket page (21.46 KB, patch)
2018-10-10 14:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20970: Reformat basket information on acquisitions basket page (21.53 KB, patch)
2018-10-19 19:24 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 20970: Reformat basket information on acquisitions basket page (21.61 KB, patch)
2018-10-23 15:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20970: Add preventDefault to avoid trailing # to be added to the url (1.73 KB, patch)
2018-10-23 15:09 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-06-20 16:00:45 UTC
Created attachment 76213 [details]
GIF showing new forms interaction

I'd like to propose a couple of minor changes to the way information and forms are displayed on the acquisitions basket view page:

- Hide form controls until the user clicks a link
- Move some information into the second column to make it a little more balanced.
Comment 1 Owen Leonard 2018-06-20 16:16:09 UTC Comment hidden (obsolete)
Comment 2 Caroline Cyr La Rose 2018-08-03 21:28:54 UTC
This looks way better than the grey buttons.

I did have a couple of problems though
1) I had trouble applying the patch, I had to add manually basket.tt and then resume applying.
2) Once the patch is applied, if I click on "Add user", nothing happens, but if I remove the patch, and click on "Add user", the pop-up appears.
3) Same thing if I click on "Set library" or "Change basket group"

And my other comment is purely personal, I love the way it looks, but it adds one click. To change a basket group, for example, you have to click on "Change basket group", then choose the basket group in the drop down, and save (4 clicks). Whereas now, you just choose the basket group in the drop down and save (3 clicks). It's not the end of the world, and I can absolutely live with one click more, but I just wanted to throw it out there.
Comment 3 Owen Leonard 2018-08-06 19:13:02 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2018-08-06 19:14:37 UTC
Thanks for testing Caroline. I proposed this change because I think the benefit of a compact and (I hope) more readable display outweighs the downside of an extra click.

I've rebased the patch. Can you try again?
Comment 5 Caroline Cyr La Rose 2018-08-06 21:52:52 UTC
The patch applies fine now. Everything works as advertised.

That might be beyond your remodeling changes, but maybe we could ditch the "Save changes" button when adding/deleting users? It would save a click (hehe!), and I don't find it super intuitive to have to save once the user appears on the page. When deleting a user, I get that you need a confirmation so that people don't delete users by accident, but even then, I don't find "Save changes" intuitive. And also, if I make a change without saving, and leave the page, there is no warning that I'm leaving unsaved changes (like in the system preferences pages, for example).
Comment 6 Owen Leonard 2018-08-07 13:04:55 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2018-08-07 13:05:59 UTC
(In reply to Caroline Cyr La Rose from comment #5)
> The patch applies fine now. Everything works as advertised.
> 
> That might be beyond your remodeling changes, but maybe we could ditch the
> "Save changes" button when adding/deleting users? 

Good idea! I was able to make it so for the managing library and basket group selection.
Comment 8 Owen Leonard 2018-09-20 12:54:30 UTC
Created attachment 79172 [details] [review]
Bug 20970: Reformat basket information on acquisitions basket page

This patch reformats the display of information on the acquisitions
basket page, hiding form controls until they are triggered. Some basket
information is now in the second column in order to balance the two
columns better.

The "Library" label has been replaced with the more precise "Managing
library."

Unrelated change: Removed script type attributes.

To test, apply the patch and view a basket in acquisitions. Test these
processes:

- Adding and removing managing users
- Setting and changing managing library
- Setting and changing basket group
Comment 9 Séverine Queune 2018-10-06 10:17:27 UTC
When IndependentBranches in on, it's not possible to choose the only available site for 'managing library' : the page never reload.

Works fine for 'users' and 'basket group'.
Comment 10 Owen Leonard 2018-10-10 14:39:46 UTC
Created attachment 80354 [details] [review]
Bug 20970: Reformat basket information on acquisitions basket page

This patch reformats the display of information on the acquisitions
basket page, hiding form controls until they are triggered. Some basket
information is now in the second column in order to balance the two
columns better.

The "Library" label has been replaced with the more precise "Managing
library."

Unrelated change: Removed script type attributes.

To test, apply the patch and view a basket in acquisitions. Test these
processes:

- Adding and removing managing users
- Setting and changing managing library
- Setting and changing basket group
Comment 11 Caroline Cyr La Rose 2018-10-19 19:24:01 UTC
Created attachment 80954 [details] [review]
Bug 20970: Reformat basket information on acquisitions basket page

This patch reformats the display of information on the acquisitions
basket page, hiding form controls until they are triggered. Some basket
information is now in the second column in order to balance the two
columns better.

The "Library" label has been replaced with the more precise "Managing
library."

Unrelated change: Removed script type attributes.

To test, apply the patch and view a basket in acquisitions. Test these
processes:

- Adding and removing managing users
- Setting and changing managing library
- Setting and changing basket group

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 12 Jonathan Druart 2018-10-23 15:09:22 UTC
Created attachment 81028 [details] [review]
Bug 20970: Reformat basket information on acquisitions basket page

This patch reformats the display of information on the acquisitions
basket page, hiding form controls until they are triggered. Some basket
information is now in the second column in order to balance the two
columns better.

The "Library" label has been replaced with the more precise "Managing
library."

Unrelated change: Removed script type attributes.

To test, apply the patch and view a basket in acquisitions. Test these
processes:

- Adding and removing managing users
- Setting and changing managing library
- Setting and changing basket group

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Jonathan Druart 2018-10-23 15:09:29 UTC
Created attachment 81029 [details] [review]
Bug 20970: Add preventDefault to avoid trailing # to be added to the url

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Nick Clemens 2018-11-05 14:57:43 UTC
Awesome work all!

Pushed to master for 18.11
Comment 15 Martin Renvoize 2018-11-16 12:27:14 UTC
Enhancement, will not be backported to 18.05.x series.