Bug 21029 - "Suspend until" in modal in staff patron account is not translatable
Summary: "Suspend until" in modal in staff patron account is not translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 16242
Blocks:
  Show dependency tree / graph
 
Reported: 2018-07-02 16:47 UTC by Katrin Fischer
Modified: 2019-10-14 19:57 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21029: Make "Suspend until:" translatable (2.16 KB, patch)
2018-07-04 17:56 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 21029: Make "Suspend until:" translatable (2.20 KB, patch)
2018-07-04 20:29 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 21029: Make "Suspend until:" translatable (2.30 KB, patch)
2018-07-06 07:53 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-07-02 16:47:58 UTC 
To test:
- Place a hold on an item
- Go to the patron account
- Click on the Suspend button on the holds tab
- View the modal, the label before the date field "Suspend until:" is not translatable.

The label is part of the holds.js file. As .js files are never translatable it needs to be moved to template level.
Comment 1 Jonathan Druart 2018-07-04 17:56:21 UTC 
Created attachment 76697 [details] [review]
Bug 21029: Make "Suspend until:" translatable

The label was part of the holds.js file. As .js files are never
translatable it needs to be moved to template level.

Test plan:
- Place a hold on an item
- Go to the patron account
- Click on the Suspend button on the holds tab
- View the modal, the label before the date field "Suspend until:" is
now translatable.
Comment 2 Katrin Fischer 2018-07-04 20:29:30 UTC 
Created attachment 76700 [details] [review]
Bug 21029: Make "Suspend until:" translatable

The label was part of the holds.js file. As .js files are never
translatable it needs to be moved to template level.

Test plan:
- Place a hold on an item
- Go to the patron account
- Click on the Suspend button on the holds tab
- View the modal, the label before the date field "Suspend until:" is
now translatable.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Marcel de Rooy 2018-07-06 07:53:54 UTC 
Created attachment 76717 [details] [review]
Bug 21029: Make "Suspend until:" translatable

The label was part of the holds.js file. As .js files are never
translatable it needs to be moved to template level.

Test plan:
- Place a hold on an item
- Go to the patron account
- Click on the Suspend button on the holds tab
- View the modal, the label before the date field "Suspend until:" is
now translatable.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Nick Clemens (kidclamp) 2018-07-06 14:42:09 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-07-10 06:36:58 UTC 
Pushed to 18.05.x for 18.05.02
Comment 6 Fridolin Somers 2018-07-12 06:39:48 UTC 
Pushed to 17.11.x for 17.11.08