When using Rancor, 007 field editor, you select the material type, and as soon as the record is saved, it reverts to the first material type in the list. The information is saved correctly, but every time the record gets edited the correct material type has to be selected again or else it is saved as the material type listed first in the dropdown.
Created attachment 86131 [details] [review] Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types
Created attachment 86218 [details] [review] Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types Signed-off-by: Michal Denar <black23@gmail.com>
I am sorry Julian, but this doesn't appear to work for me. - Open Advanced catalog editor - Select first value of 007 (ER) - Try to save (error about missing mandatory) - 007 is reset to BKS Updating severity of this bug - data loss.
Created attachment 86351 [details] [review] Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types
Created attachment 86352 [details] [review] Bug 21049: Set 007/00 when selecting material type (Rancor) There is a 1-1 relationship between the material type values and the position 00 of 007 field. Selecting a material type should set this position's value.
(In reply to Katrin Fischer from comment #3) > I am sorry Julian, but this doesn't appear to work for me. > > - Open Advanced catalog editor > - Select first value of 007 (ER) > - Try to save (error about missing mandatory) > - 007 is reset to BKS > > Updating severity of this bug - data loss. If I understand correctly, you didn't set manually the position 0 of field 007 (the first select is not bound to any MARC data, it just modifies the editor line display). I added a patch that automatically set position 0 automatically, so this should work as expected now.
This fixes the 007, howver while testing this I discovered the same issue happens on the 008. Will check for a bug for that, and if none will file one. Signing off on this fix for the 007. Cheers, Liz
Created attachment 86848 [details] [review] Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86849 [details] [review] Bug 21049: Set 007/00 when selecting material type (Rancor) There is a 1-1 relationship between the material type values and the position 00 of 007 field. Selecting a material type should set this position's value. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86935 [details] [review] Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86936 [details] [review] Bug 21049: Set 007/00 when selecting material type (Rancor) There is a 1-1 relationship between the material type values and the position 00 of 007 field. Selecting a material type should set this position's value. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
backported to 18.05.x for 18.05.12
Pushed to 17.11.x for 17.11.18