Bug 21054 - Extra closing body tag in sco-main.tt prevents slip printing
Summary: Extra closing body tag in sco-main.tt prevents slip printing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on: 16732
Blocks:
  Show dependency tree / graph
 
Reported: 2018-07-09 13:24 UTC by Nick Clemens (kidclamp)
Modified: 2019-10-14 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21054: Remove extraneous </body> tag from sco-main.tt (1.04 KB, patch)
2018-07-09 13:26 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 21054: Remove extraneous </body> tag from sco-main.tt (1.11 KB, patch)
2018-07-12 10:01 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2018-07-09 13:24:34 UTC 
Bug 16732 added an extra closing body tag to sco-main.tt 

Bug 18387 notes that page errors kick the SCO user out.

The extra body tag creates an html error and prevents receipt printing
Comment 1 Nick Clemens (kidclamp) 2018-07-09 13:26:48 UTC 
Created attachment 76793 [details] [review]
Bug 21054: Remove extraneous </body> tag from sco-main.tt

To test:
1 - Enable sco and setup AutoSelfCheck
2 - Try to use self checkout and print receipt
3 - You shoudl be redirected to the login page
4 - Apply patch and restart all the things
5 - Try to use self checkout and print a receipt
6 - Success!
Comment 2 Martin Renvoize (ashimema) 2018-07-12 10:01:31 UTC 
Created attachment 76880 [details] [review]
Bug 21054: Remove extraneous </body> tag from sco-main.tt

To test:
1 - Enable sco and setup AutoSelfCheck
2 - Try to use self checkout and print receipt
3 - You shoudl be redirected to the login page
4 - Apply patch and restart all the things
5 - Try to use self checkout and print a receipt
6 - Success!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2018-07-12 10:01:59 UTC 
Very trivial fix, works as expected, Signing Off.
Comment 4 Martin Renvoize (ashimema) 2018-07-12 10:19:52 UTC 
So trivial I've decided to just pass qa directly.
Comment 5 Nick Clemens (kidclamp) 2018-07-13 11:27:12 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize (ashimema) 2018-07-15 18:42:08 UTC 
Pushed to 18.05.x for 18.05.02
Comment 7 Fridolin Somers 2018-07-26 07:57:36 UTC 
Pushed to 17.11.x for 17.11.08

I'm trying to visualize a body without bottom XD
Comment 8 Fridolin Somers 2018-09-24 13:24:55 UTC 
Pushed to 17.05.x for 17.05.14