Some libraries use a homepage outside of koha and a widget to open the catalog. When doing this the overdrive.js is unable to access the window.opener properties and dies.
Created attachment 76965 [details] [review] Bug 21078: ovedrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From an source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console
Created attachment 79327 [details] [review] Bug 21078: ovedrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From an source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, Signing off.
Created attachment 79544 [details] [review] Bug 21078: overdrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From a source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.11