When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron
Hum, maybe it comes from local changes.
I've seen this too, just now. Not sure what local change could have done it tbh.
Did you solve it, Jonathan?
I think bug 20828 broke this - the attributes fall back in line when the homebound feature is enabled.
I confirm it still exists indeed.
(In reply to Jonathan Druart from comment #0) > To recreate: > 1. Create 1+ authorised values PA_CLASS > 2. Create patron's attributes using it > 3. Edit a patron 4. Turn HouseboundModule on
(In reply to Jonathan Druart from comment #0) > To recreate: > 1. Create 1+ authorised values PA_CLASS > 2. Create patron's attributes using it > 3. Edit a patron 4. Turn HouseboundModule off (!)
Ha, it does not happen 100% of the time, it depends on the order of the fieldset and the ol elements
Created attachment 81598 [details] [review] Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken!
Created attachment 81617 [details] [review] Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 81645 [details] [review] Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Took a little bit of playing, but see the error and confirm it's fixed!
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Pushed to 17.11.x for 17.11.13