Try the authority linker plugin dependent bugs applied. To test: - Go to catalouging - Start a new record with the default framework - Click on the authority linker on 100$a - Don't change any setting in the form and type "smi" into the first input field "main heading" - The auto-complete feature will suggest several Smiths (assuming you are using the standard sample data, otherwise look for another example with multiple results) - Pick one of the Smiths (note: all headings shown include some kind of punctuation, like a comma between firstname and surname). - Search for the selected heading. - Verify there are no search results. - Remove any punctuation - Verify the correct record is now found
Created attachment 82868 [details] [review] Bug 21084: Fix automatic truncation in authority search - Makes token splitting work like in biblio search - Only adds right hand truncation since that's what Zebra also does - Only adds truncation if the token is not a phrase and ends in a word character - Adds tests to existing and new QueryBuilder functions Test plan: 1. Create an authority record for "Duck, Donald" 2. Try contains type authority searches with the following terms and make sure they find the record: Duck, Donald donald duck don duck "Duck, Donald" 3. Make sure the following search works but does not find anything: "Duck, Don"
Created attachment 82966 [details] [review] Bug 21084: Fix automatic truncation in authority search - Makes token splitting work like in biblio search - Only adds right hand truncation since that's what Zebra also does - Only adds truncation if the token is not a phrase and ends in a word character - Adds tests to existing and new QueryBuilder functions Test plan: 1. Create an authority record for "Duck, Donald" 2. Try contains type authority searches with the following terms and make sure they find the record: Duck, Donald donald duck don duck "Duck, Donald" 3. Make sure the following search works but does not find anything: "Duck, Don" Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Assuming Nick forgot to switch status!
Created attachment 83852 [details] [review] Bug 21084: Fix automatic truncation in authority search - Makes token splitting work like in biblio search - Only adds right hand truncation since that's what Zebra also does - Only adds truncation if the token is not a phrase and ends in a word character - Adds tests to existing and new QueryBuilder functions Test plan: 1. Create an authority record for "Duck, Donald" 2. Try contains type authority searches with the following terms and make sure they find the record: Duck, Donald donald duck don duck "Duck, Donald" 3. Make sure the following search works but does not find anything: "Duck, Don" Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Much better!
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
Merge conflicts with 18.05. Will not be backported.