When using the specify due date option and then created a fast add, the checkbox "Remember for sesssion" gets automatically checked and even after unchecking it and using "Clean" the date keeps reappearing until you switch to another patron account. To test: - Set the specify due date option to a date, don't check the checkbox - Enter an unknown barcode - Click on fast add - Add a record - Add an item (don't change the barcode!) - The item is checked out to the patron - Verify: The checkbox is "Remember for session" is checked now - Uncheck checkbox and clear the specified date - Check out another item - Verify that the date is back. So there is 2 problems here: - Checkbox should not check itself - it shoudl be able to clear the date
Tested with 17.11.06, need to retest in master.
Almost the same issue on master, checkbox will be checked, but clearing it works better: To test: - Set the specify due date option to a date, don't check the checkbox - Enter an unknown barcode - Click on fast add - Add a record - Add an item (don't change the barcode!) - The item is checked out to the patron - Verify: The checkbox is "Remember for session" is checked now
*** Bug 12551 has been marked as a duplicate of this bug. ***
Still valid in master. I'm changing this from enhancement to bug, setting it to normal.
In additem.pl when doing a fast add we always set the value for stickyduedate=1, instead we should pass it the actual value from $fa_stickyduedate.
Created attachment 124634 [details] [review] Bug 21093: In additem.pl set the right stickyduedate for fast add To test: -1 Set the specify due date option to a date, don't check the checkbox -2 Enter an unknown barcode -3 Click on fast add -4 Add a record -5 Add an item (don't change the barcode!) -6 The item is checked out to the patron -7 Verify: The checkbox is "Remember for session" is checked now -8 APPLY patch -9 Do steps 1-6 again, this time "Remember for session" should be unchecked -10 Do steps 1-6 again but this time do check the "Remember for session" checkbox. -11 It should be properly checked
Created attachment 124653 [details] [review] Bug 21093: In additem.pl set the right stickyduedate for fast add To test: -1 Set the specify due date option to a date, don't check the checkbox -2 Enter an unknown barcode -3 Click on fast add -4 Add a record -5 Add an item (don't change the barcode!) -6 The item is checked out to the patron -7 Verify: The checkbox is "Remember for session" is checked now -8 APPLY patch -9 Do steps 1-6 again, this time "Remember for session" should be unchecked -10 Do steps 1-6 again but this time do check the "Remember for session" checkbox. -11 It should be properly checked Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 124813 [details] [review] Bug 21093: In additem.pl set the right stickyduedate for fast add To test: -1 Set the specify due date option to a date, don't check the checkbox -2 Enter an unknown barcode -3 Click on fast add -4 Add a record -5 Add an item (don't change the barcode!) -6 The item is checked out to the patron -7 Verify: The checkbox is "Remember for session" is checked now -8 APPLY patch -9 Do steps 1-6 again, this time "Remember for session" should be unchecked -10 Do steps 1-6 again but this time do check the "Remember for session" checkbox. -11 It should be properly checked Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.11
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.