There's a missing optgroup closing tag in orderreceive.tt. Modern browsers tend to tidy HTML so it probably goes unnoticed, but it's a good idea to fix up our markup I reckon.
Created attachment 77152 [details] [review] Bug 21097 - Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund
Created attachment 77157 [details] [review] Bug 21097 - Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Going straight to Passed QA as it's such a trivial patch and it tests as it should :)
Please read https://wiki.koha-community.org/wiki/Commit_messages#Examples Then use the QA script to catch such errors.
Created attachment 77162 [details] [review] Bug 21097: Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Grr.. I ran the qa script but entirely missed the bad commit message line :(..
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Pushed to 17.11.x for 17.11.10