During the onboarding process in installation, the creation of an Administrator patron always fails with the error, "The patron has not been created! Cardnumber or Userid may already exist." git bisect blames Bug 20287: Move AddMember to Koha::Patron->store
Created attachment 77447 [details] [review] Bug 21149: Fix superlibrarian creation in onboarding See bug 21087 for more details. Test plan: Drop your DB Start the installation process Use the onboarding process to install missing data The superlibrarian created during this process should be created sucessfully and allowed to login
I wrote bug 19185 to catch issues during the install/onboarding process
Created attachment 77450 [details] [review] Bug 21149: Fix superlibrarian creation in onboarding See bug 21087 for more details. Test plan: Drop your DB Start the installation process Use the onboarding process to install missing data The superlibrarian created during this process should be created sucessfully and allowed to login Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 77485 [details] [review] Bug 21149: Fix superlibrarian creation in onboarding See bug 21087 for more details. Test plan: Drop your DB Start the installation process Use the onboarding process to install missing data The superlibrarian created during this process should be created sucessfully and allowed to login Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected and no failures on the qa scripts. Looks good to me, Passing QA
I have the selenium tests bug and it's dependency of the separate db's for testing on my list for early next week. Lets get some tests in place to prevent a re-occurrence :)
Awesome work all! Pushed to master for 18.11
Depends on (and is caused by) but 20287 which is not in 18.05.x series.