Created attachment 77464 [details] [review] Bug 21154: Remove unused subs from C4::Serials Test plan: Run these commands, grep should not return any occurences, prove should return green: git grep GetSerialStatusFromSerialId git grep GetDistributedTo git grep SetDistributedTo git grep SetDistributedto git grep in_array git grep is_barcode_in_use kshell prove t/db_dependent/Serials.t
Created attachment 77480 [details] [review] Bug 21154: Remove unused subs from C4::Serials Test plan: Run these commands, grep should not return any occurences, prove should return green: git grep GetSerialStatusFromSerialId git grep GetDistributedTo git grep SetDistributedTo git grep SetDistributedto git grep in_array git grep is_barcode_in_use kshell prove t/db_dependent/Serials.t Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com>
Created attachment 77493 [details] [review] Bug 21154: Remove unused subs from C4::Serials Test plan: Run these commands, grep should not return any occurences, prove should return green: git grep GetSerialStatusFromSerialId git grep GetDistributedTo git grep SetDistributedTo git grep SetDistributedto git grep in_array git grep is_barcode_in_use kshell prove t/db_dependent/Serials.t Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
I'm opting to add a deprecation warning into these subs instead of removing them in the 18.05.x series. The hope is that it will serve as a friendly warning to those tracking 18.05.x who may be using these routines in local customisations stating it's removal in 18.11.x.
Deprecation Warning pushed to 18.05.x for 18.05.03
Subs in use in 17.11.x
*** Bug 21171 has been marked as a duplicate of this bug. ***