Bug 21157 - Improve style of OPAC login modal
Summary: Improve style of OPAC login modal
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-03 16:48 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot showing the updated login form (16.79 KB, image/png)
2018-08-03 16:48 UTC, Owen Leonard
Details
Bug 21157: Improve style of OPAC login modal (3.94 KB, patch)
2018-08-03 17:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21157: Improve style of OPAC login modal (3.91 KB, patch)
2018-08-13 14:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21157: Improve style of OPAC login modal (3.96 KB, patch)
2018-08-16 07:27 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 21157: Improve style of OPAC login modal (4.02 KB, patch)
2018-08-21 20:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-08-03 16:48:25 UTC
Created attachment 77478 [details]
Screenshot showing the updated login form

The OPAC login modal looks boring. I propose an update to it.
Comment 1 Owen Leonard 2018-08-03 17:00:47 UTC
Created attachment 77479 [details] [review]
Bug 21157: Improve style of OPAC login modal

This patch revises the style of the OPAC's login form modal view. The
goal is simply to make it look nicer.

To test, apply the patch and regenerate the OPAC's CSS
(https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files).

In the OPAC, click the "Log in to your account" link at the top of the
page. It should trigger the login modal. While the modal is displayed,
resize the browser width to confirm that the form handles different
widths well.

Sign off if you think this is an improvement.
Comment 2 Owen Leonard 2018-08-13 14:15:19 UTC
Created attachment 77744 [details] [review]
Bug 21157: Improve style of OPAC login modal

This patch revises the style of the OPAC's login form modal view. The
goal is simply to make it look nicer.

To test, apply the patch and regenerate the OPAC's CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

In the OPAC, click the "Log in to your account" link at the top of the
page. It should trigger the login modal. While the modal is displayed,
resize the browser width to confirm that the form handles different
widths well.

Sign off if you think this is an improvement.
Comment 3 Claire Gravely 2018-08-16 07:27:03 UTC
Created attachment 77875 [details] [review]
Bug 21157: Improve style of OPAC login modal

This patch revises the style of the OPAC's login form modal view. The
goal is simply to make it look nicer.

To test, apply the patch and regenerate the OPAC's CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

In the OPAC, click the "Log in to your account" link at the top of the
page. It should trigger the login modal. While the modal is displayed,
resize the browser width to confirm that the form handles different
widths well.

Sign off if you think this is an improvement.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 4 Jonathan Druart 2018-08-17 15:58:21 UTC
As we do no longer have a "Cancel" link I would suggest to replace '×' with icon-remove and make it bigger. Would you agree? here or later?
Comment 5 Katrin Fischer 2018-08-21 20:28:38 UTC
Created attachment 78054 [details] [review]
Bug 21157: Improve style of OPAC login modal

This patch revises the style of the OPAC's login form modal view. The
goal is simply to make it look nicer.

To test, apply the patch and regenerate the OPAC's CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

In the OPAC, click the "Log in to your account" link at the top of the
page. It should trigger the login modal. While the modal is displayed,
resize the browser width to confirm that the form handles different
widths well.

Sign off if you think this is an improvement.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Nick Clemens 2018-08-30 14:11:35 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize 2018-09-05 10:34:25 UTC
Enhancement, will not be backported to 18.05.x series