Add a reference in the system preference description saying this syspref requires a cronjob in order to work properly. Something like "Note: This system preference requires the misc/cronjobs/blah-blah.pl. Ask you system administrator to schedule it." The following system preferences require cronjobs. The starred sysprefs already have a reference to their cronjob, but it would be nice to standardize the message. - StaticHoldsQueueWeight: misc/cronjobs/holds/build_holds_queue.pl - ExpireReservesMaxPickUpDelay: misc/cronjobs/holds/cancel_expired_holds.pl - AutoResumeSuspendedHolds: misc/cronjobs/holds/auto_unsuspend_holds.pl - * finesMode: misc/cronjobs/fines.pl - DefaultLongOverdueLostValue: misc/cronjobs/longoverdue.pl - DefaultLongOverdueChargeValue: misc/cronjobs/longoverdue.pl - PatronSelfRegistrationExpireTemporaryAccountsDelay: misc/cronjobs/delete_expired_opac_registrations.pl - PatronSelfRegistrationVerifyByEmail: misc/cronjobs/delete_unverified_opac_registrations.pl - EnhancedMessagingPreferences: misc/cronjobs/process_message_queue.pl & misc/cronjobs/advance_notices.pl - NewItemsDefaultLocation: misc/cronjobs/cart_to_shelf.pl - InProcessingToShelvingCart: misc/cronjobs/cart_to_shelf.pl - ReturnToShelvingCart: misc/cronjobs/cart_to_shelf.pl - * AuthorityMergeLimit: misc/migration_tools/merge_authority.pl - * OpacBrowser: misc/cronjobs/build_browser_and_cloud.pl - * OpacCloud: misc/cronjobs/build_browser_and_cloud.pl - * UsageStats: share_usage_with_koha_community.pl - * PurgeSuggestionsOlderThan: misc/cronjobs/purge_suggestions.pl - MembershipExpiryDaysNotice: misc/cronjobs/membership_expiry.pl
Created attachment 77484 [details] [review] Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct.
Ran into issue trying to apply: vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 21158 Bug 21158 - Add cronjob references to the system preference descriptions if a cronjob is required 77484 - Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required /home/vagrant/kohaclone/.git/rebase-apply/patch:184: trailing whitespace. - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/holds/build_holds_queue.pl</code> cronjob. Ask you system administrator to schedule it." warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref <stdin>:184: trailing whitespace. - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/holds/build_holds_queue.pl</code> cronjob. Ask you system administrator to schedule it." warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Failed to merge in the changes. Patch failed at 0001 Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21158-Add-cronjob-references-to-the-system-pre-0j9bCi.patch
Created attachment 80953 [details] [review] Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct.
Created attachment 81608 [details] [review] Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. Followed test plan and patch is as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 81795 [details] [review] Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. Followed test plan and patch is as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=12258
Created attachment 81796 [details] [review] Bug 12258: (QA follow-up) Add some missing rrrrrrs Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06... It's never a bad thing to be a little bit clearer.
I prefer not to push to 17.11.x to avoid translation work
(In reply to Katrin Fischer from comment #6) > Created attachment 81796 [details] [review] [review] > Bug 12258: (QA follow-up) Add some missing rrrrrrs > > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Oups commit message is with wrong bug number 12258 instead of 21158.
Why PatronSelfRegistrationVerifyByEmail?
Also, all these paths are wrong for every installation except a dev installation...