my $itemnumbers = GetItemnumbersForBiblio($biblionumber); will become my $itemnumbers = [ Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") ];
Created attachment 77685 [details] [review] Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") Test plan: - Use the GetAvailability service of ILS-DI - Try to place a hold on an item that is available and another one - Use the batch record deletion tool to remove record with and without items.
Created attachment 77686 [details] [review] Bug 21201: Remove GetItemnumbersForBiblio
Created attachment 77964 [details] [review] Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") Test plan: - Use the GetAvailability service of ILS-DI - Try to place a hold on an item that is available and another one - Use the batch record deletion tool to remove record with and without items. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77965 [details] [review] Bug 21201: Remove GetItemnumbersForBiblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78114 [details] [review] Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") Test plan: - Use the GetAvailability service of ILS-DI - Try to place a hold on an item that is available and another one - Use the batch record deletion tool to remove record with and without items. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 78115 [details] [review] Bug 21201: Remove GetItemnumbersForBiblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.