Bug 21207 - C4::Overdues::GetItems is not used
Summary: C4::Overdues::GetItems is not used
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 15449
  Show dependency tree / graph
 
Reported: 2018-08-10 16:09 UTC by Jonathan Druart
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21207: Remove unused RM C4::Overdues::GetItems sub (1.87 KB, patch)
2018-08-10 16:12 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 21207: Remove unused RM C4::Overdues::GetItems sub (1.92 KB, patch)
2018-08-21 15:11 UTC, Josef Moravec 		Details | Diff | Splinter Review
Bug 21207: Remove unused RM C4::Overdues::GetItems sub (1.97 KB, patch)
2018-08-21 22:12 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-08-10 16:09:58 UTC 
And should be removed.
Comment 1 Jonathan Druart 2018-08-10 16:12:32 UTC 
Created attachment 77702 [details] [review]
Bug 21207: Remove unused RM C4::Overdues::GetItems sub

Test plan:
  git grep GetItems
  | grep -v GetItemsInCollection
  | grep -v GetItemsForInventory
  | grep -v GetItemsInfo
  | grep -v GetItemsLocationInfo
  | grep -v GetItemsAvailable
  | grep -v GetItemsByBiblioitemnumber

should not return any occurrences of code in perl scripts
Comment 2 Josef Moravec 2018-08-21 15:11:14 UTC 
Created attachment 78045 [details] [review]
Bug 21207: Remove unused RM C4::Overdues::GetItems sub

Test plan:
  git grep GetItems
  | grep -v GetItemsInCollection
  | grep -v GetItemsForInventory
  | grep -v GetItemsInfo
  | grep -v GetItemsLocationInfo
  | grep -v GetItemsAvailable
  | grep -v GetItemsByBiblioitemnumber

should not return any occurrences of code in perl scripts

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Katrin Fischer 2018-08-21 22:12:06 UTC 
Created attachment 78059 [details] [review]
Bug 21207: Remove unused RM C4::Overdues::GetItems sub

Test plan:
  git grep GetItems
  | grep -v GetItemsInCollection
  | grep -v GetItemsForInventory
  | grep -v GetItemsInfo
  | grep -v GetItemsLocationInfo
  | grep -v GetItemsAvailable
  | grep -v GetItemsByBiblioitemnumber

should not return any occurrences of code in perl scripts

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Nick Clemens (kidclamp) 2018-08-30 14:12:28 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-09-05 10:41:33 UTC 
Pushed to 18.05.x for 18.05.04.
Comment 6 Fridolin Somers 2018-09-24 09:20:57 UTC 
Not a bug, I prefer not to push to 17.11.x