koha_1 | # No tests run! koha_1 | koha_1 | # Failed test 'No tests run for subtest "_koha_notify_reserve() tests"' koha_1 | # at t/db_dependent/Reserves.t line 672. koha_1 | Can't call method "to_address" on an undefined value at t/db_dependent/Reserves.t line 658. koha_1 | # Looks like your test exited with 11 just after 56. koha_1 | [13:19:36] t/db_dependent/Reserves.t ...................................... koha_1 | Dubious, test returned 11 (wstat 2816, 0xb00) koha_1 | Failed 2/57 subtests
Created attachment 77837 [details] [review] Bug 21230: Prevent Reserves.t to fail randomly The following test can fail if the hold has been generated with found => 'W': # Failed test 'No tests run for subtest "_koha_notify_reserve() tests"' # at t/db_dependent/Reserves.t line 675. Can't call method "to_address" on an undefined value at t/db_dependent/Reserves.t line 661. # Looks like your test exited with 255 just after 56. We should call AddReserve instead. Test plan: 0. Do not apply this patch 1. Do the following change: my $hold = $builder->build({ source => 'Reserve', value => { borrowernumber=>$hold_borrower, found => 'W', # This line is added, do not forget the comma above } }); 2. Prove it makes the test fail 3. stash the changes and apply this patch 4. Make sure the tests pass
Created attachment 77901 [details] [review] Bug 21230: Prevent Reserves.t to fail randomly The following test can fail if the hold has been generated with found => 'W': # Failed test 'No tests run for subtest "_koha_notify_reserve() tests"' # at t/db_dependent/Reserves.t line 675. Can't call method "to_address" on an undefined value at t/db_dependent/Reserves.t line 661. # Looks like your test exited with 255 just after 56. We should call AddReserve instead. Test plan: 0. Do not apply this patch 1. Do the following change: my $hold = $builder->build({ source => 'Reserve', value => { borrowernumber=>$hold_borrower, found => 'W', # This line is added, do not forget the comma above } }); 2. Prove it makes the test fail 3. stash the changes and apply this patch 4. Make sure the tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 77926 [details] [review] Bug 21230: Prevent Reserves.t to fail randomly The following test can fail if the hold has been generated with found => 'W': # Failed test 'No tests run for subtest "_koha_notify_reserve() tests"' # at t/db_dependent/Reserves.t line 675. Can't call method "to_address" on an undefined value at t/db_dependent/Reserves.t line 661. # Looks like your test exited with 255 just after 56. We should call AddReserve instead. Test plan: 0. Do not apply this patch 1. Do the following change: my $hold = $builder->build({ source => 'Reserve', value => { borrowernumber=>$hold_borrower, found => 'W', # This line is added, do not forget the comma above } }); 2. Prove it makes the test fail 3. stash the changes and apply this patch 4. Make sure the tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Resolves as promised, Passing QA
Awesome work all! Pushed top master for 18.11
Pushed to 18.05.x for 18.05.03
Pushed to 17.11.x for 17.11.10