The code seems to make the assumption that if we come from circ, we only want to view the borrowers info, however, it provides the full form, indicating you can search for more info. To recreate: 1 - Pull up a patron 2 - Click 'Modification log' 3 - You see info about patron 4 - Change the form, moving Object to Info 5 - You are sent to a blank circ page
Created attachment 77975 [details] [review] Bug 21242: If not searching for patron, move to log viewer To test: 1 - Bring up a patron 2 - Click 'Modification log' 3 - Note you get borrower info 4 - Move the object field into info field 5 - Submit 6 - You are now on the 'Log viewer' page with admin options, not borrower circ options
Created attachment 77990 [details] [review] Bug 21242: If not searching for patron, move to log viewer To test: 1 - Bring up a patron 2 - Click 'Modification log' 3 - Note you get borrower info 4 - Move the object field into info field 5 - Submit 6 - You are now on the 'Log viewer' page with admin options, not borrower circ options Signed-off-by: Owen Leonard <oleonard@myacpl.org>
And what about making "object" read-only if viewing logs from a given patron? https://snag.gy/rqolXT.jpg
Created attachment 77994 [details] [review] [ALTERNATIVE-PATCH] Bug 21242: Make object's input read-only when viewing patron's logs
Nick, Owen, what about this alternative patch?
(In reply to Jonathan Druart from comment #5) > Nick, Owen, what about this alternative patch? Hmm...this still allows for odd things - the borrowernumber is locked, but I can change the moduel to "Catalog", then I get the info for the biblio with the same number, and I have circ options with no patron. If we want to go that route I would suggest to disable the whole form and replacing it with a link to the log viewer I don't hate my patch though :-b
(In reply to Nick Clemens from comment #6) > I don't hate my patch though :-b Ok, let's ask for another QA point of view.
This is a hard one. The basic problem seems to be that we use the log viewer in a specific context: related to one patron. But as it's a general search form there is no guarantee that people won't search for other things as well. I don't like the alternative patch so much as it feels too limiting without reason. Why do we not allow it to change and force users to make more clicks if it's the same form they get when coming from tools? I don't have a perfect solution, but I feel Nick's patch is an improvement over the current behavior.
Created attachment 81418 [details] [review] Bug 21242: If not searching for patron, move to log viewer To test: 1 - Bring up a patron 2 - Click 'Modification log' 3 - Note you get borrower info 4 - Move the object field into info field 5 - Submit 6 - You are now on the 'Log viewer' page with admin options, not borrower circ options Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Patch depends on Bug 18789. Since it is a minor impact, I choose not to push to 17.11.x