When creating lists from the staff search results page, clicking 'More Lists' launches cgi-bin/koha/virtualshelves/addbybiblionumber.pl in a new window. If the existing lists are all public, only the 'Add to a new list' fieldset is visable. If a private list is added, the 'Select an existing list' fieldset comes in to view. --- To re-create: Start with an account that has no private lists defined. 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is not an available option Add a private list, then repeat steps 2-4, note that 'Select an existing list' now shows on the 'Add to a list' page.
Caused by commit c089df3f3b45782516b63d22c34bc265c667dd35 Bug 17886: Don't show option to add to existing list if there are no lists
Created attachment 78829 [details] [review] Bug 21297: Display public lists to existing lists when adding a new item If there are no private lists the public lists are not displayed. Test plan: 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is an available option
Note for QA: The logic is correct OPAC side.
The test should say add *more than* 10 lists. The "More lists" option only appeared after I added my 11th list. But otherwise, the patch works :)
Created attachment 79292 [details] [review] Bug 21297: Display public lists to existing lists when adding a new item If there are no private lists the public lists are not displayed. Test plan: 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is an available option Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05.
Pushed to 17.11.x for 17.11.11
*** Bug 21566 has been marked as a duplicate of this bug. ***