There are two two-column cataloging templates which can be updated to use the Bootstrap grid. - cataloguing\editor.tt - cataloguing\additem.tt
Created attachment 78358 [details] [review] Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates and updates a couple of <script>s to use the Asset plugin. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items
Created attachment 78428 [details] [review] Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates and updates a couple of <script>s to use the Asset plugin. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
A scrollbar appears and the "status bar" is no longer displayed at the bottom of the screen (it is displayed but at the bottom of the page).
Created attachment 86085 [details] [review] Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates and updates a couple of <script>s to use the Asset plugin. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items
Created attachment 86086 [details] [review] Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar.
Comment on attachment 86085 [details] [review] Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging Review of attachment 86085 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ +378,5 @@ > + </div> <!-- /.col-sm-10.col-sm-push-2 --> > + > + <div class="col-sm-2 col-sm-pull-10"> > + <aside> > + [% INCLUDE 'admin-menu.inc' %] This should be deleted
Created attachment 86109 [details] Rancor glitch
Created attachment 86462 [details] [review] Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items
Created attachment 86463 [details] [review] Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar.
Created attachment 86464 [details] [review] Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well.
Created attachment 87949 [details] [review] Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 87950 [details] [review] Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 87951 [details] [review] Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 88134 [details] [review] Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88135 [details] [review] Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88136 [details] [review] Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enahancement will not be backported to 18.11.x series.