A report from one of our partner libraries: "It would be nice if the system told us what our search was. We are often interrupted and then come back and have to get back into our previous work flow. ... it would be nice to see the search parameter explicitly shown in the breadcrumb trail - or somewhere" The breadcrumb trail showed Home › Acquisitions › Orders search › Search results ... and there was no indication of what had been searched for in the URL, or anywhare on the page (aside from implicitly in the returned results). I ran several searches from cgi-bin/koha/acqui/histsearch.pl myself, and confirmed this. To re-create: 1) Navigate to Home › Acquisitions 2) Click on 'Orders Search' under the masthead search bar 3) Search for a title and click 'Submit' 4) Run a browser search for the the title, note that it appears only in the results.
Created attachment 78359 [details] Screenshot of search results, search for Title 'test'
Created attachment 85525 [details] [review] Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog.
I don't think it is signed off...
Created attachment 85913 [details] [review] Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. Signed-off-by: Bin Wen <bin.wen@inlibro.com>
(In reply to Bin from comment #4) > > Signed-off-by: Bin Wen <bin.wen@inlibro.com> Bin, you should also change status of report to "Signed off" when you are signing off.
Created attachment 88078 [details] [review] Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Seems ok to me !
Created attachment 88114 [details] [review] Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I like it!
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.