Bug 21317 - Format long lists under Koha Team tab as columns
Summary: Format long lists under Koha Team tab as columns
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-05 14:13 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Koha's team of developers is always growing ☺. This patch changes the display from a long list to a nicely formatted four column layout.
Version(s) released in:


Attachments
Bug 21317: Format long lists under Koha Team tab as columns (3.09 KB, patch)
2018-09-05 15:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21317: Format long lists under Koha Team tab as columns (3.15 KB, patch)
2018-09-05 15:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21317: Format long lists under Koha Team tab as columns (3.23 KB, patch)
2018-09-16 21:58 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-09-05 14:13:15 UTC
CSS3 columns have good browser coverage these days. I propose we format the dev tem and contributing companies lists as columns reduce scrolling on this page.
Comment 1 Owen Leonard 2018-09-05 15:08:48 UTC
Created attachment 78438 [details] [review]
Bug 21317: Format long lists under Koha Team tab as columns

This patch adds a couple of new CSS classes for formatting content in
columns: .columns-3 and .columns-4. The four-column class is applied to
the dev team and contributing companies lists on the about page.

The patch also modifies the style of H3 on this page to improve
readability.

Unrelated: "Nelsonville Public Library" corrected to "Athens County
Public Libraries."

To test, apply the patch and regenerate staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View the various tabs on the about page and confirm that everything
looks good. Confirm that the dev team and contributing companies lists
are formatted as columns.
Comment 2 Martin Renvoize 2018-09-05 15:55:02 UTC
Created attachment 78447 [details] [review]
Bug 21317: Format long lists under Koha Team tab as columns

This patch adds a couple of new CSS classes for formatting content in
columns: .columns-3 and .columns-4. The four-column class is applied to
the dev team and contributing companies lists on the about page.

The patch also modifies the style of H3 on this page to improve
readability.

Unrelated: "Nelsonville Public Library" corrected to "Athens County
Public Libraries."

To test, apply the patch and regenerate staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View the various tabs on the about page and confirm that everything
looks good. Confirm that the dev team and contributing companies lists
are formatted as columns.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2018-09-05 15:55:27 UTC
Looks much better, signing off.
Comment 4 Jonathan Druart 2018-09-15 22:42:35 UTC
columns-3 added to scss but do not used, is it expected?
Comment 5 Owen Leonard 2018-09-16 21:30:59 UTC
(In reply to Jonathan Druart from comment #4)
> columns-3 added to scss but do not used, is it expected?

I added it because it thought it would be useful for possible future use.
Comment 6 Jonathan Druart 2018-09-16 21:57:43 UTC
Content of li can be split: start at the bottom of one column and finish at the top of the next column. Passing QA anyway.
Comment 7 Jonathan Druart 2018-09-16 21:58:13 UTC
Created attachment 79016 [details] [review]
Bug 21317: Format long lists under Koha Team tab as columns

This patch adds a couple of new CSS classes for formatting content in
columns: .columns-3 and .columns-4. The four-column class is applied to
the dev team and contributing companies lists on the about page.

The patch also modifies the style of H3 on this page to improve
readability.

Unrelated: "Nelsonville Public Library" corrected to "Athens County
Public Libraries."

To test, apply the patch and regenerate staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View the various tabs on the about page and confirm that everything
looks good. Confirm that the dev team and contributing companies lists
are formatted as columns.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Nick Clemens 2018-09-16 23:10:02 UTC
Awesome work all!

Pushed to master for 18.11
Comment 9 Martin Renvoize 2018-09-17 14:39:22 UTC
Enhancement, will not be backported to 18.05.x series.