Bug 21319 - Remove highlight and tooltip on Koha Team version
Summary: Remove highlight and tooltip on Koha Team version
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-06 10:26 UTC by Martin Renvoize
Modified: 2019-10-14 19:56 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Two years ago we switched the version numbering system from 3.x to YY.MM format. At that time we added a tooltip and highlighted the version in red on the Koha Team tab of the about page. This patch removes that now that a sufficient period of time has passed.
Version(s) released in:


Attachments
Bug 21319: Remove highlight and tooltip on Koha Team version (1.42 KB, patch)
2018-09-06 12:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Patch signed-off (1.49 KB, patch)
2018-09-06 19:36 UTC, Pierre-Marc Thibault
Details | Diff | Splinter Review
Bug 21319: Remove highlight and tooltip on Koha Team version (1.56 KB, patch)
2018-09-07 06:42 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2018-09-06 10:26:47 UTC
Two years ago we switch the version numbering system from 3.x to yy.mm format. At that time we added a tooltip and highlighted the version in red on the Koha Team tab of the about page.

I think we can safely remove this now?
Comment 1 Owen Leonard 2018-09-06 12:07:08 UTC
Created attachment 78473 [details] [review]
Bug 21319: Remove highlight and tooltip on Koha Team version

This patch modifies the about page to remove a <span> on the Koha
version number which explained the version numbering change.

To test, apply the patch and view the "Koha team" tab on the about page.
The "Koha 18.05 release team" header should not have the number
highlighted.
Comment 2 Pierre-Marc Thibault 2018-09-06 19:36:35 UTC
Created attachment 78496 [details] [review]
Patch signed-off

The red highlight and the tooltip was removed successfully.
Comment 3 Martin Renvoize 2018-09-07 06:42:43 UTC
Created attachment 78501 [details] [review]
Bug 21319: Remove highlight and tooltip on Koha Team version

This patch modifies the about page to remove a <span> on the Koha
version number which explained the version numbering change.

To test, apply the patch and view the "Koha team" tab on the about page.
The "Koha 18.05 release team" header should not have the number
highlighted.

Signed-off-by: pierre-marc <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2018-09-07 06:43:48 UTC
Very simple change, passing qa.
Comment 5 Nick Clemens 2018-09-07 16:06:08 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-09-11 08:32:06 UTC
Glad to see this updated, will not be backported to 18.05.x.