opac-detail.tt contains the following: [% IF ( bidi ) %] [% BLOCK cssinclude %][% Asset.css("css/right-to-left.css") | $raw %][% END %] [% END %] This is a duplication of markup in doc-head-close.inc and can be removed.
Created attachment 84947 [details] [review] Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available
Created attachment 85184 [details] [review] Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Bug 10659 seems the be getting in the way of a clean apply. I'll rebase and submit my signoff
Created attachment 85187 [details] [review] Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 85328 [details] [review] Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
i cant rebase this in 18.05.x and pass the qa tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt SKIP filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template : filter not found skipping unless needed