It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.
Created attachment 78596 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.
Created attachment 78850 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no>
Created attachment 78852 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no>
Created attachment 78853 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no>
Created attachment 78855 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no>
Created attachment 78857 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no>
Created attachment 78866 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no>
As you can see by the excessive signed-off-by's below, I'm pretty sure Petter is experiencing this ByWater Sandboxes not signing off problem.
Created attachment 79180 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no>
Maybe a silly question, but how do you make the callnumber show up in the result list? I tried OPACItemsResultsDisplay, but that didn't work.
Turns out it helps when your items actually have callnumbers :)
Created attachment 79354 [details] [review] Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Enhancement will not be backported to 18.05.x series.