Bug 21341 - Style button on acquisitions existing record search with Bootstrap
Summary: Style button on acquisitions existing record search with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-12 17:38 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21341: Style button on acquisitions existing record search with Bootstrap (2.51 KB, patch)
2018-09-12 17:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21341: Style button on acquisitions existing record search with Bootstrap (2.56 KB, patch)
2018-09-14 23:17 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 21341: Style button on acquisitions existing record search with Bootstrap (2.64 KB, patch)
2018-09-22 13:44 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-09-12 17:38:56 UTC
When you add to a basket by searching existing records, the "View MARC" and "Order" links should be Bootstrap buttons.
Comment 1 Owen Leonard 2018-09-12 17:49:24 UTC Comment hidden (obsolete)
Comment 2 Claire Gravely 2018-09-14 23:17:06 UTC
Created attachment 78834 [details] [review]
Bug 21341: Style button on acquisitions existing record search with Bootstrap

This patch adds Bootstrap button styles to two links: View MARC and
Order.

Unrelated: A "modal-wide" class has been added to the View MARC modal to
give more room for the MARC view.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From an existing record.

In the record search results, confirm that the View MARC and Order links
are now Bootstrap buttons. Test the View MARC button and confirm that
the modal preview fills most of the screen.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Jonathan Druart 2018-09-22 13:44:55 UTC
Created attachment 79264 [details] [review]
Bug 21341: Style button on acquisitions existing record search with Bootstrap

This patch adds Bootstrap button styles to two links: View MARC and
Order.

Unrelated: A "modal-wide" class has been added to the View MARC modal to
give more room for the MARC view.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From an existing record.

In the record search results, confirm that the View MARC and Order links
are now Bootstrap buttons. Test the View MARC button and confirm that
the modal preview fills most of the screen.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-09-26 19:36:19 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-09-27 13:35:25 UTC
Enhancement, will not be backported to 18.05.x series.