Bug 21347 - bad code for input field in item information tab of addorderiso2709 page
Summary: bad code for input field in item information tab of addorderiso2709 page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on: 13618
Blocks:
  Show dependency tree / graph
 
Reported: 2018-09-14 21:09 UTC by Koha Team University Lyon 3
Modified: 2020-01-06 20:14 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21347 : Escaped fields that should be in addorderiso2709 (1.51 KB, patch)
2018-09-14 22:50 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 21347 : Escaped fields that should be in addorderiso2709 (1.55 KB, patch)
2018-09-15 16:48 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 21347: Escaped fields that should be in addorderiso2709 (1.63 KB, patch)
2018-09-15 20:52 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2018-09-14 21:09:13 UTC 
In cgi-bin/koha/acqui/addorderiso2709.pl, there is a problem with some fields in item information problem. Instead to have a field, you have the code :
 Cote <input type="text" name="field_value" value="" size="50" maxlength="255" /> 
Note <input type="text" name="field_value" value="" size="50" maxlength="255" />
Comment 1 Chris Cormack 2018-09-14 22:50:41 UTC 
Created attachment 78824 [details] [review]
Bug 21347 : Escaped fields that should be in addorderiso2709

Test plan
1/ Stage a MARC file (if you have none staged)
2/ Create a basket in aquisitions
3/ Add an order via staged file
4/ Look at the item information tab, notice there is escaped html
5/ Apply patch
6/ Refresh page, notice it is fixed
Comment 2 Koha Team University Lyon 3 2018-09-14 23:24:12 UTC 
I have followed the plan test and now the fields in item information page are correcty displayed.

Thank you Chris!
Comment 3 Biblibre Sandboxes 2018-09-15 16:48:13 UTC 
Patch tested with a sandbox, by Sonia <sonia.bouis@univ-lyon3.fr>
Comment 4 Biblibre Sandboxes 2018-09-15 16:48:38 UTC 
Created attachment 78858 [details] [review]
Bug 21347 : Escaped fields that should be in addorderiso2709

Test plan
1/ Stage a MARC file (if you have none staged)
2/ Create a basket in aquisitions
3/ Add an order via staged file
4/ Look at the item information tab, notice there is escaped html
5/ Apply patch
6/ Refresh page, notice it is fixed

Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>
Comment 5 Jonathan Druart 2018-09-15 20:52:36 UTC 
Created attachment 78892 [details] [review]
Bug 21347: Escaped fields that should be in addorderiso2709

Test plan
1/ Stage a MARC file (if you have none staged)
2/ Create a basket in aquisitions
3/ Add an order via staged file
4/ Look at the item information tab, notice there is escaped html
5/ Apply patch
6/ Refresh page, notice it is fixed

Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Nick Clemens (kidclamp) 2018-09-16 18:26:40 UTC 
Awesome work all!

Pushed to master for 18.11