When permission 'manage_patron_lists' is off, there is no checkbox on /cgi-bin/koha/members/member.pl to merge patrons.
Created attachment 78872 [details] [review] Bug 21353: Display checkboxes to merge patron even if cannot manage lists When permission 'manage_patron_lists' is off, there is no checkbox on /cgi-bin/koha/members/member.pl to merge patrons. Test plan: Remove permission manage_patron_lists Add permission edit_borrowers Search for patrons => Without this patch you will not be able to select patrons to merge (checkboxes are not displayed)
The "Select all // Clear all" options are only display with permission 'manage_patron_lists'. It think it's display should not dependant on any permission for it's useful for both actions (list + merge).
Created attachment 78957 [details] [review] Bug 21353: (follow-up) same check for select/clear all links
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78971 [details] [review] Bug 21353: Display checkboxes to merge patron even if cannot manage lists When permission 'manage_patron_lists' is off, there is no checkbox on /cgi-bin/koha/members/member.pl to merge patrons. Test plan: Remove permission manage_patron_lists Add permission edit_borrowers Search for patrons => Without this patch you will not be able to select patrons to merge (checkboxes are not displayed) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78972 [details] [review] Bug 21353: (follow-up) same check for select/clear all links Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 79335 [details] [review] Bug 21353: Display checkboxes to merge patron even if cannot manage lists When permission 'manage_patron_lists' is off, there is no checkbox on /cgi-bin/koha/members/member.pl to merge patrons. Test plan: Remove permission manage_patron_lists Add permission edit_borrowers Search for patrons => Without this patch you will not be able to select patrons to merge (checkboxes are not displayed) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 79336 [details] [review] Bug 21353: (follow-up) same check for select/clear all links Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.11
(In reply to Fridolin SOMERS from comment #11) > Pushed to 17.11.x for 17.11.11 Arf brakes template, I revert from 17.11.x