Bug 21356 - Missing space in parcel.tt
Summary: Missing space in parcel.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-15 19:55 UTC by Caroline Cyr La Rose
Modified: 2019-10-14 19:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screen capture of the place where the space is missing (12.86 KB, image/png)
2018-09-15 19:55 UTC, Caroline Cyr La Rose
Details
Bug 21356: Missing space in parcel.tt (1.52 KB, patch)
2018-09-15 20:11 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 21356: Missing space in parcel.tt (1.59 KB, patch)
2018-09-16 16:54 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 21356: Add Missing space in parcel.tt (1.67 KB, patch)
2018-09-16 16:59 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2018-09-15 19:55:13 UTC
Created attachment 78878 [details]
Screen capture of the place where the space is missing

There is no space between the user's name and "On:" (see screen capture)
Comment 1 Caroline Cyr La Rose 2018-09-15 20:11:26 UTC
Created attachment 78880 [details] [review]
Bug 21356: Missing space in parcel.tt

This patch adds a space between the user's name and 'On:'
in parcel.tt.

To test:

1) Go to Acquisitions
2) Search for a vendor
3) Create a new basket
4) Add an order to the basket
5) Close the basket
6) Receive the order
7) In the page title 'Receipt summary' notice there is no space
between the 'Received by' user name and 'On:'
8) Apply the patch
9) Refresh the page, there should now be a space
Comment 2 Jonathan Druart 2018-09-15 20:39:04 UTC
Caroline, is this ready for testing? Do not forget to switch the status to Needs Signoff as well as assign the bug report to you ;)
Comment 3 Caroline Cyr La Rose 2018-09-15 20:40:28 UTC
Right sorry! It is only my 2nd submission...
Comment 4 Fridolin Somers 2018-09-16 16:54:34 UTC
Created attachment 78938 [details] [review]
Bug 21356: Missing space in parcel.tt

This patch adds a space between the user's name and 'On:'
in parcel.tt.

To test:

1) Go to Acquisitions
2) Search for a vendor
3) Create a new basket
4) Add an order to the basket
5) Close the basket
6) Receive the order
7) In the page title 'Receipt summary' notice there is no space
between the 'Received by' user name and 'On:'
8) Apply the patch
9) Refresh the page, there should now be a space

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Comment 5 Jonathan Druart 2018-09-16 16:59:13 UTC
Created attachment 78940 [details] [review]
Bug 21356: Add Missing space in parcel.tt

This patch adds a space between the user's name and 'On:'
in parcel.tt.

To test:

1) Go to Acquisitions
2) Search for a vendor
3) Create a new basket
4) Add an order to the basket
5) Close the basket
6) Receive the order
7) In the page title 'Receipt summary' notice there is no space
between the 'Received by' user name and 'On:'
8) Apply the patch
9) Refresh the page, there should now be a space

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Nick Clemens 2018-09-16 18:22:54 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize 2018-09-17 14:34:38 UTC
Pushed to 18.05.x for 18.05.04
Comment 8 Fridolin Somers 2018-09-24 10:21:32 UTC
Useless for 17.11.x