It's possible to move between fields with tab/shift-tab but when there's a dropdown menu in a control field, it's not possible to move past it.
Created attachment 78990 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look.
Created attachment 79000 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Ere, can you add a test plan please? I have linked a control field to AV but I do not see the dropdown list. Also I think the following change is wrong: - if ( ( this.nodeName.toLowerCase() == 'select' && e.which == 9 ) || e.ctrlKey ) { + if ( e.ctrlKey && 0 ) {
Maybe he meant the default plugins? They have a lot of pull downs.
Created attachment 79191 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look. Test plan: 1. Try moving from field to field and inside control fields with tab/shift-tab. 2. Make sure focus doesn't get stuck in any position.
Thanks, Jonathan, that was indeed a leftover. Patch fixed and test plan added.
Created attachment 79210 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look. Test plan: 1. Try moving from field to field and inside control fields with tab/shift-tab. 2. Make sure focus doesn't get stuck in any position.
Fixed patch really attached.
Created attachment 79248 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look. Test plan: 1. Try moving from field to field and inside control fields with tab/shift-tab. 2. Make sure focus doesn't get stuck in any position. Signed-off-by: Michal Denar <black23@gmail.com>
Seetings > Show helpers for fixed and coded fields!
So basically you are reverting the changes made by commit 3b2d66cec899dd3b33f41041bafb785bda7e1e31 Bug 11559: (followup) fix first-character deletion, small usability issues This should fix the first-character deletion bug reported by Nick, and also: * Fix subfield deletion * Attempted fix for special keys on dropdowns * Allow deleting empty fields * Fix bug with composed characters Which was a fix for bug 11559 comment 145. I found at least one regression: "-Ctrl+D when dropdown is selected bookmarks page instead of adding a new field" Maybe we should be more specific (instead of removing conditions) and catch alt+tab and alt+shift+tab (?)
Thanks again, Jonathan. I'll check and revise once more.
Created attachment 79299 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look. Test plan: 1. Try moving from field to field and inside control fields with tab/shift-tab. 2. Make sure focus doesn't get stuck in any position.
Latest version keeps the old condition apart from bailing out from select with tab.
Hi Ere, It works. It stuck inside coded fields like 008 or on fields with lists like 942. Do You able to fix it in this or we make new bug? Short video: http://recordit.co/lYsQzCnbY4 Thank You Mike
Michal, your video shows exactly the issue I'm trying to fix with this patch. Do you still encounter it with the patch applied?
Hi, Video shows behaviour after patch. But I'm newbie, maybe some issue between keyboard and chair :-) Mike
Which browser and operating system?
Hi, Firefox 62.0.2, MacOS I'try Chrome too. Mike
Same OS and browser work for me with the patch applied. Can you verify again that you have the patch and the browser doesn't cache old widget.js?
Created attachment 79360 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look. Test plan: 1. Try moving from field to field and inside control fields with tab/shift-tab. 2. Make sure focus doesn't get stuck in any position. Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 79498 [details] [review] Bug 21362: Advanced editor: Fix tab navigation in fixed fields Also minor tweaks to how the fields look. Test plan: 1. Try moving from field to field and inside control fields with tab/shift-tab. 2. Make sure focus doesn't get stuck in any position. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.11