Bug 21365 - BiblioAddsAuthorities does not work with the Advanced MARC Editor - Rancor
Summary: BiblioAddsAuthorities does not work with the Advanced MARC Editor - Rancor
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Ere Maijala
QA Contact: Testopia
URL:
Keywords:
Depends on: 16424
Blocks:
  Show dependency treegraph
 
Reported: 2018-09-16 21:50 UTC by Ere Maijala
Modified: 2019-10-14 19:56 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21365: Make advanced MARC editor honor BiblioAddsAuthorities (1.65 KB, patch)
2018-09-16 22:14 UTC, Ere Maijala
Details | Diff | Splinter Review
Bug 21365: Make advanced MARC editor honor BiblioAddsAuthorities (1.70 KB, patch)
2018-09-24 12:24 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio (4.17 KB, patch)
2018-10-10 10:13 UTC, Ere Maijala
Details | Diff | Splinter Review
Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio (4.24 KB, patch)
2018-10-11 19:36 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio (4.29 KB, patch)
2018-10-11 23:07 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ere Maijala 2018-09-16 21:50:11 UTC

    
Comment 1 Ere Maijala 2018-09-16 22:14:40 UTC
Created attachment 79021 [details] [review]
Bug 21365: Make advanced MARC editor honor BiblioAddsAuthorities

To test:
1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled.
2. Add a new record using advanced editor, include a previously non-existing author.
3. Save the record and observe the author get an authority number.
4. Add another author, save the record and make sure it also gets an authority number.
Comment 2 Michal Denar 2018-09-24 12:24:52 UTC
Created attachment 79302 [details] [review]
Bug 21365: Make advanced MARC editor honor BiblioAddsAuthorities

To test:
1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled.
2. Add a new record using advanced editor, include a previously non-existing author.
3. Save the record and observe the author get an authority number.
4. Add another author, save the record and make sure it also gets an authority number.

Signed-off-by: Michal Denar <black23@gmail.com>
Comment 3 Jonathan Druart 2018-09-30 22:31:38 UTC
Should not it be better to call BiblioAutoLink from AddBiblio and ModBiblio?
Comment 4 Martin Renvoize 2018-10-09 09:30:04 UTC
I agree with Jonathan here, it would be cleaner to use BiblioAutoLink from within AddBiblio and ModBiblio and thus catch any other cases where this logic may have been missed (currently or in the future).
Comment 5 Ere Maijala 2018-10-10 10:13:21 UTC
Created attachment 80325 [details] [review]
Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio

This makes e.g. the advanced MARC editor, and anything that uses AddBiblio or
ModBiblio honor BiblioAddsAuthorities.

To test:
1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled.
2. Add a new record using advanced editor (enable EnableAdvancedCatalogingEditor to
use it), include a previously non-existing author.
3. Save the record and observe the author get an authority number.
4. Add another author, save the record and make sure it also gets an authority number.
Comment 6 Michal Denar 2018-10-11 19:36:56 UTC
Created attachment 80418 [details] [review]
Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio

This makes e.g. the advanced MARC editor, and anything that uses AddBiblio or
ModBiblio honor BiblioAddsAuthorities.

To test:
1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled.
2. Add a new record using advanced editor (enable EnableAdvancedCatalogingEditor to
use it), include a previously non-existing author.
3. Save the record and observe the author get an authority number.
4. Add another author, save the record and make sure it also gets an authority number.

Signed-off-by: Michal Denar <black23@gmail.com>
Comment 7 Chris Cormack 2018-10-11 23:07:27 UTC
Created attachment 80440 [details] [review]
Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio

This makes e.g. the advanced MARC editor, and anything that uses AddBiblio or
ModBiblio honor BiblioAddsAuthorities.

To test:
1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled.
2. Add a new record using advanced editor (enable EnableAdvancedCatalogingEditor to
use it), include a previously non-existing author.
3. Save the record and observe the author get an authority number.
4. Add another author, save the record and make sure it also gets an authority number.

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 8 Nick Clemens 2018-10-15 17:05:02 UTC
Awesome work all!

Pushed to master for 18.11
Comment 9 Martin Renvoize 2018-10-17 10:24:50 UTC
I would have liked to see some tests for the change to Biblio.pm here :(
Comment 10 Martin Renvoize 2018-10-17 10:33:27 UTC
Pushed to 18.05.x for 18.05.05
Comment 11 Fridolin Somers 2018-11-09 08:03:03 UTC
Depends on Bug 16424 not in 17.11.x
And I prefer not add this important change in oldstable branch.