Created attachment 79021 [details] [review] Bug 21365: Make advanced MARC editor honor BiblioAddsAuthorities To test: 1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled. 2. Add a new record using advanced editor, include a previously non-existing author. 3. Save the record and observe the author get an authority number. 4. Add another author, save the record and make sure it also gets an authority number.
Created attachment 79302 [details] [review] Bug 21365: Make advanced MARC editor honor BiblioAddsAuthorities To test: 1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled. 2. Add a new record using advanced editor, include a previously non-existing author. 3. Save the record and observe the author get an authority number. 4. Add another author, save the record and make sure it also gets an authority number. Signed-off-by: Michal Denar <black23@gmail.com>
Should not it be better to call BiblioAutoLink from AddBiblio and ModBiblio?
I agree with Jonathan here, it would be cleaner to use BiblioAutoLink from within AddBiblio and ModBiblio and thus catch any other cases where this logic may have been missed (currently or in the future).
Created attachment 80325 [details] [review] Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio This makes e.g. the advanced MARC editor, and anything that uses AddBiblio or ModBiblio honor BiblioAddsAuthorities. To test: 1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled. 2. Add a new record using advanced editor (enable EnableAdvancedCatalogingEditor to use it), include a previously non-existing author. 3. Save the record and observe the author get an authority number. 4. Add another author, save the record and make sure it also gets an authority number.
Created attachment 80418 [details] [review] Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio This makes e.g. the advanced MARC editor, and anything that uses AddBiblio or ModBiblio honor BiblioAddsAuthorities. To test: 1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled. 2. Add a new record using advanced editor (enable EnableAdvancedCatalogingEditor to use it), include a previously non-existing author. 3. Save the record and observe the author get an authority number. 4. Add another author, save the record and make sure it also gets an authority number. Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 80440 [details] [review] Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio This makes e.g. the advanced MARC editor, and anything that uses AddBiblio or ModBiblio honor BiblioAddsAuthorities. To test: 1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled. 2. Add a new record using advanced editor (enable EnableAdvancedCatalogingEditor to use it), include a previously non-existing author. 3. Save the record and observe the author get an authority number. 4. Add another author, save the record and make sure it also gets an authority number. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Awesome work all! Pushed to master for 18.11
I would have liked to see some tests for the change to Biblio.pm here :(
Pushed to 18.05.x for 18.05.05
Depends on Bug 16424 not in 17.11.x And I prefer not add this important change in oldstable branch.