On the 'New order' page in the 'Accounting details' section of the form there are clarifications on which amount (with/without tax) one is expected to enter. These clarifications should be replicated to the 'Accounting details' form on the 'Receive items from: ' page.
Created attachment 79212 [details] [review] Bug 21387: Receive items from - form should include tax hints
Would appreciate you're eye on the UI here Owen :)
We usually use a "hint" class for adding additional information to a form or similar display. To my eye it looks good inline, so <span class="hint"> around the new text. I think it would be better not to abbreviate "inc" and "exc." One problem I saw: In my test system I got this: Retail price: 18.58 Adjusted for , tax exc. I don't know why it isn't displaying the active currency. Also: This will require a rebase on top of Bug 21454, Remove html filter for Price filtered variables.
Created attachment 79751 [details] [review] Bug 21387: Receive items from - form should include tax hints
Created attachment 79753 [details] [review] Bug 21387: Receive items from - form should include tax hints
Thanks for the review Owen. I've added the "hint" classes and correct the missing currency.. seems I forgot to commit the corresponding script change.. oops. As for the abbreviation, I was trying to make it as close to the hints on the orderempty form as possible. For consistency would you prefer I change both templates or leave hat to a second bug perhaps?
I think a separate bug for expanding those abbreviations would be good. Unless there is a difficult space restraint my vote would be to avoid abbreviations whenever we can.
OK, I've created a dependent bug and asked for guidance on the approved wording at bug 21619
Created attachment 80930 [details] [review] Bug 21387: Receive items from - form should include tax hints
I ran into a problem. Here's what I did: 1) Before starting, my vendor had both "list prices" and "invoice prices" set to "don't include tax". 2) I created an order line. The hints were "tax exc.", which is ok 3) I received an item. The hints were "tax exc.", which is ok 4) I went in my vendor and changed the "list prices" and "invoices princes" and set them to "include tax" 5) I created an order line. The hints, specifically "vendor price", "retail price", "budgeted cost" and "actual cost" were "tax inc.", which is ok 6) I received the same item. The hints, specifically "retail price", "budgeted cost" and "actual cost", were "tax exc." (but the same price was written as when I ordered, tax included).
Any thoughts on the above Jonathan? I'm going to try to replicate this today, if I can it feels like a bug higher up the stack that this patch, but I'm not sure how it was intended to work.
(In reply to Caroline Cyr La Rose from comment #10) > I ran into a problem. Here's what I did: > 4) I went in my vendor and changed the "list prices" and "invoices princes" > and set them to "include tax" This step should not be done I would say, once they have been set you should not change these values.
So I should try with another vendor to see the different links? Also, if we're not supposed to change the vendor tax settings, they shouldn't be editable.
(In reply to Caroline Cyr La Rose from comment #13) > So I should try with another vendor to see the different links? > > Also, if we're not supposed to change the vendor tax settings, they > shouldn't be editable. Yes I think they should not be editable unless there is no order yet.
Thanks for your comments Jonathan, my gut feeling was the same but as you wrote most of the current tax handling code I thought you'd be best to weight in :). So perhaps a new bug to prevent editing of that setting once an order exists against the vendor... or a way to record which way the setting was set at the time of order.. either way, it feels like a new bug and shouldn't prevent this one moving forward in my opinion.
I created a new vendor and set the tax parameters to "include tax" for both invoice price and list price. When I order an item from this vendor, hints are ok (tax inc.) But when I receive the same item from this vendor, the tax hints are wrong (tax exc.) Am I understanding what this is supposed to do?
Created attachment 81639 [details] [review] Bug 21387: Receive items from - form should include tax hints
Good catch Caroline.. I'd completely missed passing a couple of variables through. Should work as expected now.. you were completely right in your testing.
The hints in ordering and receiving form now match.
Created attachment 81917 [details] [review] Bug 21387: Receive items from - form should include tax hints Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 81999 [details] [review] Bug 21387: Receive items from - form should include tax hints Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
I prefer not to change display in 17.11.x