The code used to catch missing filters (xt/find-missing-filters.t) is not isolated, which make it hard to reuse for other usages. We would like the QA tests (qa-test-tools) to have another test to catch them, which would let us (developpers, QAers, RM) know earlier in the workflow that something is wrong.
Created attachment 79236 [details] [review] Bug 21393: Move missing filters code to a module To make it reusable easily from QA test tools https://gitlab.com/koha-community/qa-test-tools/issues/3
Created attachment 79237 [details] [review] Bug 21393: Add tests
Created attachment 79238 [details] [review] Bug 21393: Add line nubmers to ease fixing
Test plan: Confirm that the tests pass Follow the test plan from the qa-test-tools issue Found bugs!
Created attachment 79281 [details] [review] Bug 21393: Move missing filters code to a module To make it reusable easily from QA test tools https://gitlab.com/koha-community/qa-test-tools/issues/3 Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 79282 [details] [review] Bug 21393: Add tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 79283 [details] [review] Bug 21393: Add line nubmers to ease fixing Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Tested using bug 17282.
Created attachment 79535 [details] [review] Bug 21393: Move missing filters code to a module To make it reusable easily from QA test tools https://gitlab.com/koha-community/qa-test-tools/issues/3 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 79536 [details] [review] Bug 21393: Add tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 79537 [details] [review] Bug 21393: Add line nubmers to ease fixing Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Enhancement on bug not in 18.05.x series.