Bug 21393 - Make template filter checks code reusable
Summary: Make template filter checks code reusable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 13618
Blocks: 21731 21454 21770
  Show dependency treegraph
 
Reported: 2018-09-21 16:03 UTC by Jonathan Druart
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21393: Move missing filters code to a module (7.96 KB, patch)
2018-09-21 16:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21393: Add tests (4.22 KB, patch)
2018-09-21 16:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21393: Add line nubmers to ease fixing (5.57 KB, patch)
2018-09-21 16:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21393: Move missing filters code to a module (8.00 KB, patch)
2018-09-24 09:29 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21393: Add tests (4.27 KB, patch)
2018-09-24 09:29 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21393: Add line nubmers to ease fixing (5.61 KB, patch)
2018-09-24 09:29 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21393: Move missing filters code to a module (8.12 KB, patch)
2018-09-27 15:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21393: Add tests (4.38 KB, patch)
2018-09-27 15:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21393: Add line nubmers to ease fixing (5.72 KB, patch)
2018-09-27 15:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-09-21 16:03:21 UTC
The code used to catch missing filters (xt/find-missing-filters.t) is not isolated, which make it hard to reuse for other usages.

We would like the QA tests (qa-test-tools) to have another test to catch them, which would let us (developpers, QAers, RM) know earlier in the workflow that something is wrong.
Comment 1 Jonathan Druart 2018-09-21 16:15:19 UTC
Created attachment 79236 [details] [review]
Bug 21393: Move missing filters code to a module

To make it reusable easily from QA test tools
https://gitlab.com/koha-community/qa-test-tools/issues/3
Comment 2 Jonathan Druart 2018-09-21 16:15:24 UTC
Created attachment 79237 [details] [review]
Bug 21393: Add tests
Comment 3 Jonathan Druart 2018-09-21 16:15:29 UTC
Created attachment 79238 [details] [review]
Bug 21393: Add line nubmers to ease fixing
Comment 4 Jonathan Druart 2018-09-21 16:39:48 UTC
Test plan:
Confirm that the tests pass
Follow the test plan from the qa-test-tools issue
Found bugs!
Comment 5 Josef Moravec 2018-09-24 09:29:37 UTC
Created attachment 79281 [details] [review]
Bug 21393: Move missing filters code to a module

To make it reusable easily from QA test tools
https://gitlab.com/koha-community/qa-test-tools/issues/3

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Josef Moravec 2018-09-24 09:29:40 UTC
Created attachment 79282 [details] [review]
Bug 21393: Add tests

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Josef Moravec 2018-09-24 09:29:44 UTC
Created attachment 79283 [details] [review]
Bug 21393: Add line nubmers to ease fixing

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 8 Josef Moravec 2018-09-24 09:29:59 UTC
Tested using bug 17282.
Comment 9 Katrin Fischer 2018-09-27 15:55:47 UTC
Created attachment 79535 [details] [review]
Bug 21393: Move missing filters code to a module

To make it reusable easily from QA test tools
https://gitlab.com/koha-community/qa-test-tools/issues/3

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2018-09-27 15:55:51 UTC
Created attachment 79536 [details] [review]
Bug 21393: Add tests

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2018-09-27 15:55:55 UTC
Created attachment 79537 [details] [review]
Bug 21393: Add line nubmers to ease fixing

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Nick Clemens 2018-10-01 16:45:30 UTC
Awesome work all!

Pushed to master for 18.11
Comment 13 Martin Renvoize 2018-10-05 15:52:47 UTC
Enhancement on bug not in 18.05.x series.