Otherwise we get this ugly screen: https://snag.gy/U8X3ZK.jpg
Created attachment 79265 [details] [review] Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work.
Created attachment 79468 [details] [review] Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple fix, does what it says on the tin. Signing Off
Created attachment 79473 [details] [review] Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This works, but looks a bit different than other places we have required fields (no red label, no *, no red required showing up behind the field - but maybe it would not look right in this case?) No blocker for me, just noting.
Awesome work all! Pushed to master for 18.11
(In reply to Katrin Fischer from comment #5) > This works, but looks a bit different than other places we have required > fields (no red label, no *, no red required showing up behind the field - > but maybe it would not look right in this case?) No blocker for me, just > noting. The message when nothing is entered looks good so i think that suffices here
I tried the label in red but it looked bad, it takes too much visibility.
(In reply to Jonathan Druart from comment #8) > I tried the label in red but it looked bad, it takes too much visibility. I think you are right, it would be too prominent, when the search is only one valid option on the form.
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.11