Bug 21403 - Add Indian Amazon Affiliate option to AmazonLocale setting
Summary: Add Indian Amazon Affiliate option to AmazonLocale setting
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-25 05:29 UTC by Prasanth K
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
American Affiliate Tags Not use in india (114.16 KB, image/jpeg)
2018-09-25 05:29 UTC, Prasanth K
Details
Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting (3.78 KB, patch)
2018-09-25 13:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting (3.85 KB, patch)
2018-09-28 20:33 UTC, Pierre-Marc Thibault
Details | Diff | Splinter Review
Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting (3.95 KB, patch)
2018-10-01 15:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21403: Do not overwrite the options if modified locally (1.05 KB, patch)
2018-10-01 15:15 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Prasanth K 2018-09-25 05:29:56 UTC
Created attachment 79353 [details]
American Affiliate Tags Not use in india

Problem in 

More > Administration > Global System Preferences > Enhanced Content

Dear Koha Developers,
   
                Am A Indian Amazon Affiliater and Librarian. Here we using American Amazon website .com domain. So students are unable to buy books from Indian amazon link .in so add Indian amazon affiliate .in domain in content enhancement. Amazon also not providing that commission, because Amazon gives location-based commission.

Please add Indian amazon domain in enhanced content. We also happy to receive the commisom. In India most school, universities and special libraries are using Koha. That librarians get some extra hard cash.
Comment 1 Owen Leonard 2018-09-25 13:27:12 UTC
Created attachment 79373 [details] [review]
Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting

This patch adds an "IN" option to the AmazonLocale setting, allowing
Indian libraries to use their Amazon Affiliate ID in Koha's links to
Amazon.

To test, apply the patch and run updatedatabase.

- Go to Administration -> System preferences -> Enhanced content.
- Enable the OPACAmazonCoverImages preference.
- Enter a dummy ID in the AmazonAssocTag preference.
- Confirm that you can select "Indian" for the AmazonLocale preference.
- Select "Indian" and save.
- Open a record in the OPAC and confirm that the cover image links to
  Amazon.in and includes the ID you entered in AmazonAssocTag.
- Do the same with a record in the staff client.
Comment 2 Pierre-Marc Thibault 2018-09-28 20:33:25 UTC
Created attachment 79608 [details] [review]
Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting

This patch adds an "IN" option to the AmazonLocale setting, allowing
Indian libraries to use their Amazon Affiliate ID in Koha's links to
Amazon.

To test, apply the patch and run updatedatabase.

- Go to Administration -> System preferences -> Enhanced content.
- Enable the OPACAmazonCoverImages preference.
- Enter a dummy ID in the AmazonAssocTag preference.
- Confirm that you can select "Indian" for the AmazonLocale preference.
- Select "Indian" and save.
- Open a record in the OPAC and confirm that the cover image links to
  Amazon.in and includes the ID you entered in AmazonAssocTag.
- Do the same with a record in the staff client.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Comment 3 Jonathan Druart 2018-10-01 15:15:13 UTC
Created attachment 79735 [details] [review]
Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting

This patch adds an "IN" option to the AmazonLocale setting, allowing
Indian libraries to use their Amazon Affiliate ID in Koha's links to
Amazon.

To test, apply the patch and run updatedatabase.

- Go to Administration -> System preferences -> Enhanced content.
- Enable the OPACAmazonCoverImages preference.
- Enter a dummy ID in the AmazonAssocTag preference.
- Confirm that you can select "Indian" for the AmazonLocale preference.
- Select "Indian" and save.
- Open a record in the OPAC and confirm that the cover image links to
  Amazon.in and includes the ID you entered in AmazonAssocTag.
- Do the same with a record in the staff client.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2018-10-01 15:15:17 UTC
Created attachment 79736 [details] [review]
Bug 21403: Do not overwrite the options if modified locally

Just in case...

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Nick Clemens 2018-10-02 00:14:01 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-10-08 08:30:44 UTC
Enhancement, will not be backported to 18.05.x series.