Bug 21404 - Remove unused variables in C4::Breeding->_auth_build_query
Summary: Remove unused variables in C4::Breeding->_auth_build_query
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Keywords:
Depends on: 21318
Blocks:
  Show dependency treegraph
 
Reported: 2018-09-25 05:59 UTC by Josef Moravec
Modified: 2019-10-14 19:58 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query (1.14 KB, patch)
2018-09-25 07:07 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21404: Update test (2.12 KB, patch)
2018-09-25 07:07 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21404: Refactor _build_query subroutines (1.95 KB, patch)
2018-09-25 07:07 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query (1.18 KB, patch)
2018-09-26 18:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21404: Update test (2.17 KB, patch)
2018-09-26 18:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21404: Refactor _build_query subroutines (2.00 KB, patch)
2018-09-26 18:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query (1.24 KB, patch)
2018-09-27 12:39 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21404: Update test (2.23 KB, patch)
2018-09-27 12:39 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21404: Refactor _build_query subroutines (2.06 KB, patch)
2018-09-27 12:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2018-09-25 05:59:44 UTC

    
Comment 1 Josef Moravec 2018-09-25 07:07:12 UTC
Created attachment 79357 [details] [review]
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query
Comment 2 Josef Moravec 2018-09-25 07:07:15 UTC
Created attachment 79358 [details] [review]
Bug 21404: Update test
Comment 3 Josef Moravec 2018-09-25 07:07:19 UTC
Created attachment 79359 [details] [review]
Bug 21404: Refactor _build_query subroutines

Test plan:
1) Apply the patch
2) prove t/db_dependent/Breeding.t
3) Try to search using Z39.50, both, authority and biblio should still
work
Comment 4 Owen Leonard 2018-09-26 18:46:50 UTC
Created attachment 79443 [details] [review]
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2018-09-26 18:46:54 UTC
Created attachment 79444 [details] [review]
Bug 21404: Update test

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2018-09-26 18:46:57 UTC
Created attachment 79445 [details] [review]
Bug 21404: Refactor _build_query subroutines

Test plan:
1) Apply the patch
2) prove t/db_dependent/Breeding.t
3) Try to search using Z39.50, both, authority and biblio should still
work

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Katrin Fischer 2018-09-27 12:39:35 UTC
Created attachment 79492 [details] [review]
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2018-09-27 12:39:39 UTC
Created attachment 79493 [details] [review]
Bug 21404: Update test

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2018-09-27 12:39:44 UTC
Created attachment 79494 [details] [review]
Bug 21404: Refactor _build_query subroutines

Test plan:
1) Apply the patch
2) prove t/db_dependent/Breeding.t
3) Try to search using Z39.50, both, authority and biblio should still
work

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Nick Clemens 2018-10-01 16:45:44 UTC
Awesome work all!

Pushed to master for 18.11
Comment 11 Martin Renvoize 2018-10-05 12:17:30 UTC
Depends on bug 21318 not in 18.05.x, caused by bug 19436 not in 18.05.x.  Marking as RESOLVED FIXED