Noted by Kyle in passing in bug 21417 - basketno was failing to be interpolated into the error message. and should be moved out of the string Have changed the two cases where basketno was appearing in a carp message to catenate the basketno onto the end of the error string. Tested by passing passing orderlines parameters but suppressing others so that error message is invoked
Created attachment 79480 [details] [review] Patch to correctly display basketno
Created attachment 79487 [details] [review] Bug 21425 Display basketno correctly in Order error msg carp will display the hash value instead of the desired basketno in the error message unless we change its behaviour Use the simpler but effective option of concatenating the errormessage with the basketno. Error is shown if no sender or receipient ean is passed in instantiating an Koha::Edifact::Order object Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Still no test for this module?
Created attachment 79667 [details] [review] Bug 21425 Display basketno correctly in Order error msg carp will display the hash value instead of the desired basketno in the error message unless we change its behaviour Use the simpler but effective option of concatenating the errormessage with the basketno. Error is shown if no sender or receipient ean is passed in instantiating an Koha::Edifact::Order object Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.11