Bug 21433 - Switch two-column templates to Bootstrap grid: Tools part 1
Summary: Switch two-column templates to Bootstrap grid: Tools part 1
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Josef Moravec
URL:
Keywords:
Depends on:
Blocks: 20654
  Show dependency tree / graph
 
Reported: 2018-09-27 14:26 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1 (10.79 KB, patch)
2018-09-27 14:40 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1 (10.94 KB, patch)
2018-10-08 21:19 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1 (11.00 KB, patch)
2018-10-29 21:49 UTC, Josef Moravec 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-09-27 14:26:16 UTC 
These two-column tools templates can be updated to use the Bootstrap grid.

 - tools/automatic_item_modification_by_age.tt
 - tools/batchMod.tt
 - tools/batch_delete_records.tt
 - tools/batch_record_modification.tt
 - tools/cleanborrowers.tt
 - tools/csv-profiles.tt
Comment 1 Owen Leonard 2018-09-27 14:40:05 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass (lukeg) 2018-10-08 21:19:45 UTC 
Created attachment 80239 [details] [review]
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Automatic item modifications by age
   - View and edit rules
 - Tools -> Batch item modification start page
 - Tools -> Batch delete records
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch record modification
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch patron deletion/anonymization
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> CSV profiles
   - View and edit CSV profiles

Signed-off-by: “Lucas Gass” <lucas@bywatersolutions.com>
Comment 3 Josef Moravec 2018-10-29 21:49:00 UTC 
Created attachment 81592 [details] [review]
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Automatic item modifications by age
   - View and edit rules
 - Tools -> Batch item modification start page
 - Tools -> Batch delete records
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch record modification
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch patron deletion/anonymization
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> CSV profiles
   - View and edit CSV profiles

Signed-off-by: “Lucas Gass” <lucas@bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Nick Clemens (kidclamp) 2018-11-08 02:27:18 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-11-16 12:55:05 UTC 
Enhancement, will not be backported to 18.05.x series.