Bug 21437 - Switch two-column templates to Bootstrap grid: Patron lists
Summary: Switch two-column templates to Bootstrap grid: Patron lists
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 20654
  Show dependency tree / graph
 
Reported: 2018-09-27 15:05 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21437: Update two-column templates with Bootstrap grid: Patron lists (4.66 KB, patch)
2018-09-27 15:09 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 21437: Update two-column templates with Bootstrap grid: Patron lists (4.71 KB, patch)
2018-09-28 12:41 UTC, Michal Denar 		Details | Diff | Splinter Review
Bug 21437: Update two-column templates with Bootstrap grid: Patron lists (4.79 KB, patch)
2018-10-01 00:07 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-09-27 15:05:07 UTC 
These two-column patron lists templates can be updated to use the Bootstrap grid.

 - patron_lists/list.tt
 - patron_lists/lists.tt
Comment 1 Owen Leonard 2018-09-27 15:09:40 UTC 
Created attachment 79526 [details] [review]
Bug 21437: Update two-column templates with Bootstrap grid: Patron lists

This patch modifies the patron lists templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Patron lists
   -> View patron list
Comment 2 Michal Denar 2018-09-28 12:41:31 UTC 
Created attachment 79574 [details] [review]
Bug 21437: Update two-column templates with Bootstrap grid: Patron lists

This patch modifies the patron lists templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Patron lists
   -> View patron list

Signed-off-by: Michal Denar <black23@gmail.com>
Comment 3 Jonathan Druart 2018-10-01 00:07:41 UTC 
Created attachment 79683 [details] [review]
Bug 21437: Update two-column templates with Bootstrap grid: Patron lists

This patch modifies the patron lists templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Patron lists
   -> View patron list

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens (kidclamp) 2018-10-01 16:46:12 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-10-08 07:59:35 UTC 
Enhancement, will not be backported to 18.05.x series.