Bug 21448 - Field 606 doesn't add multiple x subfields
Summary: Field 606 doesn't add multiple x subfields
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 18904
Blocks:
  Show dependency treegraph
 
Reported: 2018-09-28 13:35 UTC by José Anjos
Modified: 2019-10-14 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx (1.56 KB, patch)
2018-09-29 19:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx (1.70 KB, patch)
2018-10-01 12:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx (1.75 KB, patch)
2018-10-01 22:02 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description José Anjos 2018-09-28 13:35:31 UTC
On field 606, if I use an Authority with multiple "x" subfields, it will add
just the first "x"
This is a bug from recent koha versions because it was working with our
Koha until now.
I've tested with BibLibre demo (http://intranet-demo.biblibre.com/) and it
works fine (Ver 17.11)
With 18.05 doesn't work.

This is happening with MARC 21 as reported by Elaine Bradtke here:
http://koha.1045719.n5.nabble.com/Field-606-doesnt-add-multiple-x-subfields-td5992111.html
Comment 1 Jonathan Druart 2018-09-29 19:03:58 UTC
Caused by
  commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551
  Bug 18904: (follow-up) Retrieve subfield in the order they are stored
Comment 2 Jonathan Druart 2018-09-29 19:10:07 UTC
Created attachment 79620 [details] [review]
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx

The reported issue was:
On field 606, if I use an Authority with multiple "x" subfields, it will
add just the first "x"

Error in the logs:
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97.

We should pass a ref (!), caused by
  commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551
  Bug 18904: (follow-up) Retrieve subfield in the order they are stored

Test plan:
Edit an authority and add several $x to 600
Link this authority to a bibliographic record
=> Without this patch only the first subfield is copied
=> With this patch applied they are all copied
Comment 3 José Anjos 2018-10-01 08:36:19 UTC
(In reply to Jonathan Druart from comment #2)
> Created attachment 79620 [details] [review] [review]
> Bug 21448: Fix copy repeated subfields when linking an authority with 6xx
> 
> The reported issue was:
> On field 606, if I use an Authority with multiple "x" subfields, it will
> add just the first "x"
> 
> Error in the logs:
> Odd number of elements in anonymous hash at
> /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97.
> 
> We should pass a ref (!), caused by
>   commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551
>   Bug 18904: (follow-up) Retrieve subfield in the order they are stored
> 
> Test plan:
> Edit an authority and add several $x to 600
> Link this authority to a bibliographic record
> => Without this patch only the first subfield is copied
> => With this patch applied they are all copied

Tested. It works fine :)
Thank you very much
Comment 4 Jonathan Druart 2018-10-01 12:23:45 UTC
Created attachment 79710 [details] [review]
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx

The reported issue was:
On field 606, if I use an Authority with multiple "x" subfields, it will
add just the first "x"

Error in the logs:
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97.

We should pass a ref (!), caused by
  commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551
  Bug 18904: (follow-up) Retrieve subfield in the order they are stored

Test plan:
Edit an authority and add several $x to 600
Link this authority to a bibliographic record
=> Without this patch only the first subfield is copied
=> With this patch applied they are all copied

Signed-off-by: José Anjos <joseanjos@gmail.com>
Comment 5 Jonathan Druart 2018-10-01 12:24:58 UTC
Hi José, thanks for testing.
Do not forget to adjust the status, see also https://wiki.koha-community.org/wiki/Sign_off_on_patches
Comment 6 Chris Cormack 2018-10-01 22:02:02 UTC
Created attachment 79787 [details] [review]
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx

The reported issue was:
On field 606, if I use an Authority with multiple "x" subfields, it will
add just the first "x"

Error in the logs:
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97.

We should pass a ref (!), caused by
  commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551
  Bug 18904: (follow-up) Retrieve subfield in the order they are stored

Test plan:
Edit an authority and add several $x to 600
Link this authority to a bibliographic record
=> Without this patch only the first subfield is copied
=> With this patch applied they are all copied

Signed-off-by: José Anjos <joseanjos@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 7 Nick Clemens 2018-10-02 00:14:59 UTC
Awesome work all!

Pushed to master for 18.11
Comment 8 Martin Renvoize 2018-10-08 08:20:51 UTC
Pushed to 18.05.x for 18.05.05
Comment 9 Fridolin Somers 2018-10-11 13:20:05 UTC
Bug 18904 not in 17.11.x