As per the attached screenshots, when you perform an authority search in the staff client and click on the 'Search' button, the selected values for the 'Search all headings:' and 'Search entire record:' options get flipped around.
Created attachment 79650 [details] Authority search window before clicking on 'Search'
Created attachment 79651 [details] Authority search window after clicking on 'Search'
Created attachment 79652 [details] [review] Bug 21455: Authority search options get shuffled around when you click on 'Search' In the staff client, when you perform an authority search the selected values for the 'Search all headings:' and 'Search entire record:' options get shuffled around when you click on the 'Search' button. This patch fixes that. Test plan: 1) Perform an authority search and set the 'Search all headings:' option to 'starts with'. 2) Click on the 'Search' button. 3) Notice how the 'Search all headings:' option is now 'contains', and 'starts with' has moved down to the 'Search entire record:' option. 4) Apply the patch. 5) Hit 'Search' again. This time the selected search options do not move around.
Created attachment 80149 [details] [review] Bug 21455: Authority search options get shuffled around when you click on 'Search' In the staff client, when you perform an authority search the selected values for the 'Search all headings:' and 'Search entire record:' options get shuffled around when you click on the 'Search' button. This patch fixes that. Test plan: 1) Perform an authority search and set the 'Search all headings:' option to 'starts with'. 2) Click on the 'Search' button. 3) Notice how the 'Search all headings:' option is now 'contains', and 'starts with' has moved down to the 'Search entire record:' option. 4) Apply the patch. 5) Hit 'Search' again. This time the selected search options do not move around. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
This doesn't work for me yet, when I search, the tab still jumps back to the first. (applied patch, restart all, reloaded the page mulitple times)
Looking at the screenshots... I am in the wrong spot. I had checked the normal authority search. Filed a bug: Bug 21510 - Authority search always jumps back to the first search tab no matter what was searched for
Created attachment 80167 [details] [review] Bug 21455: Authority search options get shuffled around when you click on 'Search' In the staff client, when you perform an authority search the selected values for the 'Search all headings:' and 'Search entire record:' options get shuffled around when you click on the 'Search' button. This patch fixes that. Test plan: 1) Perform an authority search and set the 'Search all headings:' option to 'starts with'. 2) Click on the 'Search' button. 3) Notice how the 'Search all headings:' option is now 'contains', and 'starts with' has moved down to the 'Search entire record:' option. 4) Apply the patch. 5) Hit 'Search' again. This time the selected search options do not move around. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #5) > This doesn't work for me yet, when I search, the tab still jumps back to the > first. (applied patch, restart all, reloaded the page mulitple times) My bad really, now that I re-read the bug description and test plan for the patch I realise I should have been more explicit. Nevertheless it's interesting to see how your testing led to the discovery of yet another authorities-related bug! ;-)
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.12