As per the attached staff client screenshots, in Home > Authorities (authorities-home.pl), the button 'New authority' lists the available authority types in alphabetical order based on their _description_. The same button in an authority's detail view (detail.pl) lists auth types in alphabetical order based on their _code_.
Created attachment 79653 [details] Authority types sorted by description
Created attachment 79654 [details] Authority types sorted by code
Created attachment 79655 [details] [review] Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description.
Created attachment 79661 [details] [review] Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 80223 [details] [review] Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 80224 [details] [review] Bug 21456: (QA follow-up) Catch missed case in authorities merge Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Added followup to be consistent across the board. Passing QA.
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Small enhancement, nearly a bug so pushed to 17.11.x for 17.11.12