$item should be $items, if patron is queued for a biblio _get_outstanding_holds will crash (but not caught since evaluated in eval context). Since this is a trivial fix I will not write a how to test, since fix should be obvious just looking at the code.
Created attachment 79817 [details] [review] Bug 21471: Misspelled variable in _get_outstanding_holds Misspelled variable causes _get_outstanding_holds to crash if patron is queued on biblio level
Created attachment 79851 [details] [review] Bug 21471: Misspelled variable in _get_outstanding_holds Misspelled variable causes _get_outstanding_holds to crash if patron is queued on biblio level Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Oops, sorry! Caused by commit 62a075987af70ec5ed3665fe662adb31a17fdde4 Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls
Created attachment 79900 [details] [review] Bug 21471: (bug 21184 follow-up) Misspelled variable in _get_outstanding_holds Misspelled variable causes _get_outstanding_holds to crash if patron is queued on biblio level Caused by commit 62a075987af70ec5ed3665fe662adb31a17fdde4 Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Caused by bug 21184 not in 18.05.x series.