Bug 21471 - Misspelled variable name in _get_outstanding_holds
Summary: Misspelled variable name in _get_outstanding_holds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P1 - high critical (vote)
Assignee: David Gustafsson
QA Contact: Testopia
URL:
Keywords:
Depends on: 21184
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-02 11:36 UTC by David Gustafsson
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21471: Misspelled variable in _get_outstanding_holds (956 bytes, patch)
2018-10-02 11:40 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 21471: Misspelled variable in _get_outstanding_holds (1011 bytes, patch)
2018-10-02 20:22 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 21471: (bug 21184 follow-up) Misspelled variable in _get_outstanding_holds (1.21 KB, patch)
2018-10-03 15:29 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Gustafsson 2018-10-02 11:36:25 UTC
$item should be $items, if patron is queued for a biblio _get_outstanding_holds will crash (but not caught since evaluated in eval context). Since this is a trivial fix I will not write a how to test, since fix should be obvious just looking at the code.
Comment 1 David Gustafsson 2018-10-02 11:40:45 UTC
Created attachment 79817 [details] [review]
Bug 21471: Misspelled variable in _get_outstanding_holds

Misspelled variable causes _get_outstanding_holds to crash
if patron is queued on biblio level
Comment 2 Chris Cormack 2018-10-02 20:22:28 UTC
Created attachment 79851 [details] [review]
Bug 21471: Misspelled variable in _get_outstanding_holds

Misspelled variable causes _get_outstanding_holds to crash
if patron is queued on biblio level

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 3 Jonathan Druart 2018-10-03 15:27:29 UTC
Oops, sorry!

Caused by 
  commit 62a075987af70ec5ed3665fe662adb31a17fdde4
  Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls
Comment 4 Jonathan Druart 2018-10-03 15:29:40 UTC
Created attachment 79900 [details] [review]
Bug 21471: (bug 21184 follow-up) Misspelled variable in _get_outstanding_holds

Misspelled variable causes _get_outstanding_holds to crash
if patron is queued on biblio level

Caused by
  commit 62a075987af70ec5ed3665fe662adb31a17fdde4
    Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Nick Clemens 2018-10-05 16:26:02 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-10-08 08:44:31 UTC
Caused by bug 21184 not in 18.05.x series.