Bug 21493 - Remove incomplete icon style from serial issues tabs
Summary: Remove incomplete icon style from serial issues tabs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 18385 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-04 18:37 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21493: Remove incomplete icon style from serial issues tabs (2.36 KB, patch)
2018-10-04 18:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21493: Remove incomplete icon style from serial issues tabs (2.43 KB, patch)
2018-10-08 13:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21493: Remove incomplete icon style from serial issues tabs (2.48 KB, patch)
2018-10-08 20:25 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 21493: (18.05.x) Remove incomplete icon style from serial issues tabs (1.65 KB, patch)
2018-10-15 13:24 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-10-04 18:37:58 UTC
When viewing the brief or full history of a subscription's issues, there are tab links for "Normal view," "Brief history," and "Full history." These links are incorrectly inheriting an incomplete style: The default sprite is specified but no background-position. Since there are no icons intended for these tabs the background image should be removed.
Comment 1 Owen Leonard 2018-10-04 18:58:36 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2018-10-08 13:27:37 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2018-10-08 13:28:10 UTC
Always like a bit of cleaning up.. thanks Owen, signing off.
Comment 4 Chris Cormack 2018-10-08 20:25:16 UTC
Created attachment 80234 [details] [review]
Bug 21493: Remove incomplete icon style from serial issues tabs

This patch adds CSS to exclude serial issues history links from having
an icon background. There is no part of the icon sprite which is
designed for that purpose.

This patch also tweaks the positioning of a couple of icons and makes
other minor corrections to related CSS.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Open the detail page for a bibliographic record in the OPAC which has
  subscriptions.
- Click the "More details" link.
- Confirm that the "Brief history" and "Full history" links have no
  icon.
- Click the "Full history" link and do the same.
- On the normal, MARC, and ISBD views, confirm that the icons for those
  links look correct.
- View the purchase suggestions page as a logged-in user. Confirm that
  the "new purchase suggestion" link looks correct.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Nick Clemens 2018-10-09 16:22:02 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Owen Leonard 2018-10-15 13:24:43 UTC
Created attachment 80596 [details] [review]
Bug 21493: (18.05.x) Remove incomplete icon style from serial issues tabs

This patch adds CSS to exclude serial issues history links from having
an icon background. There is no part of the icon sprite which is
designed for that purpose.

This patch also tweaks the positioning of a couple of icons.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files).

- Open the detail page for a bibliographic record in the OPAC which has
  subscriptions.
- Click the "More details" link.
- Confirm that the "Brief history" and "Full history" links have no
  icon.
- Click the "Full history" link and do the same.
- On the normal, MARC, and ISBD views, confirm that the icons for those
  links look correct.
Comment 7 Martin Renvoize 2018-10-15 13:36:24 UTC
Thanks for the 18.05.x version Owen.

Pushed to 18.05.x for 18.05.05
Comment 8 Owen Leonard 2018-11-06 14:08:46 UTC
*** Bug 18385 has been marked as a duplicate of this bug. ***