When viewing the brief or full history of a subscription's issues, there are tab links for "Normal view," "Brief history," and "Full history." These links are incorrectly inheriting an incomplete style: The default sprite is specified but no background-position. Since there are no icons intended for these tabs the background image should be removed.
Created attachment 79963 [details] [review] Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct.
Created attachment 80218 [details] [review] Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Always like a bit of cleaning up.. thanks Owen, signing off.
Created attachment 80234 [details] [review] Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Awesome work all! Pushed to master for 18.11
Created attachment 80596 [details] [review] Bug 21493: (18.05.x) Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct.
Thanks for the 18.05.x version Owen. Pushed to 18.05.x for 18.05.05
*** Bug 18385 has been marked as a duplicate of this bug. ***