Bug 21501 - Remove dead code from course reserves module
Summary: Remove dead code from course reserves module
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-05 13:24 UTC by Julian Maurice
Modified: 2019-10-14 19:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21501: Remove dead code from course reserves module (3.07 KB, patch)
2018-10-05 13:25 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 21501: Remove dead code from course reserves module (3.14 KB, patch)
2018-10-05 19:03 UTC, Pierre-Marc Thibault
Details | Diff | Splinter Review
Bug 21501: Remove dead code from course reserves module (3.22 KB, patch)
2018-10-16 18:51 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2018-10-05 13:24:49 UTC

    
Comment 1 Julian Maurice 2018-10-05 13:25:48 UTC
Created attachment 80083 [details] [review]
Bug 21501: Remove dead code from course reserves module

search_on parameter is not used in any templates so course-reserves.pl
can be simplified a bit

Test plan:
1. Go to course reserves module and verify that it is still working
2. `git grep search_on` should return nothing
Comment 2 Pierre-Marc Thibault 2018-10-05 19:03:45 UTC
Created attachment 80146 [details] [review]
Bug 21501: Remove dead code from course reserves module

search_on parameter is not used in any templates so course-reserves.pl
can be simplified a bit

Test plan:
1. Go to course reserves module and verify that it is still working
2. `git grep search_on` should return nothing

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Comment 3 Jonathan Druart 2018-10-16 18:51:27 UTC
Created attachment 80677 [details] [review]
Bug 21501: Remove dead code from course reserves module

search_on parameter is not used in any templates so course-reserves.pl
can be simplified a bit

Test plan:
1. Go to course reserves module and verify that it is still working
2. `git grep search_on` should return nothing

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-11-02 10:44:23 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-11-16 12:16:35 UTC
Enhancement will not be backported to 18.05.x series.