Created attachment 80085 [details] [review] Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings
Created attachment 80086 [details] [review] Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check
I have one line in my UpdateItemLocationOnCheckin preference: PROC: APL-PROMO And I get the message that it is badly-formatted. Shouldn't that pass?
Created attachment 80360 [details] [review] Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings
Created attachment 80362 [details] [review] Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check
I don't have the 'UpdateItemLocationOnCheckin' preference that Owen mentioned, and no trace on Koha manual. I don't have alert for the ItemsDeniedRenewal pref, isn't that YAML too ?
(In reply to Séverine Queune from comment #6) > I don't have the 'UpdateItemLocationOnCheckin' preference that Owen > mentioned, and no trace on Koha manual. > I don't have alert for the ItemsDeniedRenewal pref, isn't that YAML too ? Hi Severine, the first will be added by the bug this depends on, so you need to apply both and run updatedatabase.
(In reply to Katrin Fischer from comment #7) > (In reply to Séverine Queune from comment #6) > > I don't have the 'UpdateItemLocationOnCheckin' preference that Owen > > mentioned, and no trace on Koha manual. > > I don't have alert for the ItemsDeniedRenewal pref, isn't that YAML too ? > > Hi Severine, the first will be added by the bug this depends on, so you need > to apply both and run updatedatabase. Argh... completely missed the dependency, sorry about that...
Created attachment 88462 [details] [review] Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings
Created attachment 88463 [details] [review] Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check
Created attachment 88464 [details] [review] Bug 21502: Add ItemsDeniedRenewal system preference to check syntax
Created attachment 88562 [details] [review] Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 88563 [details] [review] Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 88564 [details] [review] Bug 21502: Add ItemsDeniedRenewal system preference to check syntax Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 88655 [details] [review] Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88656 [details] [review] Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88657 [details] [review] Bug 21502: Add ItemsDeniedRenewal system preference to check syntax Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88664 [details] [review] Bug 21502: (QA follow-up) Rephrase warning slightly Test plan: Follow first test plan, look at warning, decide if you like it :)
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series