Created attachment 80147 [details] Additional fields box When you have additional fields in your subscription, the 'Additional fields' title appears in a blue box, but the fields themselves are outside the box.(See attached screen capture) To reproduce: 1) Go to Serials 2) Click on 'Add subscription fields' 3) Click on 'New fields' 4) Fill in the form and click 'Save' 5) Search for a subscription 6) Click on the title to see the subscription detail page 7) In the 'Information' tab, there is the 'Additional fields' title in its box followed by the additional field
Maybe also change the 'New fields' for 'New field'. All the 'New ...' buttons are singular, and we only add one field at a time.
Created attachment 80303 [details] [review] Bug 21505: Box around 'Additional fields' does not contain the fields This patch modifies the subscription detail page markup to eliminate a confusing bordered <legend> tag. It is replaced with an <hr> to delineate the sections and an <h3> tag to serve as the heading. To test, apply the patch and regenerate the staff client CSS. - Configure one or more additional subscription fields. - View the detail page for a subscription and confirm that the "Additional fields" section is clearly labeled.
(In reply to Caroline Cyr La Rose from comment #1) > Maybe also change the 'New fields' for 'New field'. All the 'New ...' > buttons are singular, and we only add one field at a time. I created Bug 21531 for this issue.
Created attachment 80392 [details] [review] Bug 21505: Box around 'Additional fields' does not contain the fields This patch modifies the subscription detail page markup to eliminate a confusing bordered <legend> tag. It is replaced with an <hr> to delineate the sections and an <h3> tag to serve as the heading. To test, apply the patch and regenerate the staff client CSS. - Configure one or more additional subscription fields. - View the detail page for a subscription and confirm that the "Additional fields" section is clearly labeled. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
I like this much better, thx!
Created attachment 80423 [details] [review] Bug 21505: Box around 'Additional fields' does not contain the fields This patch modifies the subscription detail page markup to eliminate a confusing bordered <legend> tag. It is replaced with an <hr> to delineate the sections and an <h3> tag to serve as the heading. To test, apply the patch and regenerate the staff client CSS. - Configure one or more additional subscription fields. - View the detail page for a subscription and confirm that the "Additional fields" section is clearly labeled. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Caused by bug 21523 not in 18.05.x series.
Ignore that.. the error is present in 18.05.x series too.. backporting now.
Pushed to 18.05.x for 18.05.06
I prefer not to change display in 17.11.x